Cleanup webpack sourcemap middleware source URL handling #75879

eps1lon · 2025-02-10T20:28:19Z

Mostly clarifying where we deal with source URLs instead of paths and remove some redundant or unused code.

eps1lon · 2025-02-10T20:28:37Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

ijjk · 2025-02-10T20:50:58Z

Stats from current PR

Default Build

General

	vercel/next.js canary	vercel/next.js sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling	Change
buildDuration	19.3s	17.8s	N/A
buildDurationCached	16.8s	14.2s	N/A
nodeModulesSize	393 MB	393 MB	N/A
nextStartRea..uration (ms)	456ms	462ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling	Change
5306-HASH.js gzip	55.1 kB	55.1 kB	N/A
7048.HASH.js gzip	168 B	168 B	✓
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	245 B	245 B	✓
main-HASH.js gzip	34.7 kB	34.7 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	✓
Overall change	2.12 kB	2.12 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling	Change
_app-HASH.js gzip	194 B	194 B	✓
_error-HASH.js gzip	193 B	192 B	N/A
amp-HASH.js gzip	513 B	511 B	N/A
css-HASH.js gzip	342 B	342 B	✓
dynamic-HASH.js gzip	1.84 kB	1.84 kB	N/A
edge-ssr-HASH.js gzip	265 B	264 B	N/A
head-HASH.js gzip	363 B	360 B	N/A
hooks-HASH.js gzip	393 B	390 B	N/A
image-HASH.js gzip	4.59 kB	4.59 kB	N/A
index-HASH.js gzip	268 B	266 B	N/A
link-HASH.js gzip	2.35 kB	2.35 kB	✓
routerDirect..HASH.js gzip	327 B	326 B	N/A
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	325 B	325 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.72 kB	3.72 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling	Change
_buildManifest.js gzip	749 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling	Change
index.html gzip	522 B	522 B	✓
link.html gzip	538 B	536 B	N/A
withRouter.html gzip	518 B	518 B	✓
Overall change	1.04 kB	1.04 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	211 kB	211 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling	Change
middleware-b..fest.js gzip	677 B	673 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.4 kB	31.4 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling	Change
app-page-exp...dev.js gzip	394 kB	394 kB	N/A
app-page-exp..prod.js gzip	133 kB	133 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	382 kB	382 kB	N/A
app-page.run..prod.js gzip	129 kB	129 kB	✓
app-route-ex...dev.js gzip	39.4 kB	39.4 kB	✓
app-route-ex..prod.js gzip	25.7 kB	25.7 kB	✓
app-route-tu..prod.js gzip	25.7 kB	25.7 kB	✓
app-route-tu..prod.js gzip	25.5 kB	25.5 kB	✓
app-route.ru...dev.js gzip	41 kB	41 kB	✓
app-route.ru..prod.js gzip	25.5 kB	25.5 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.72 kB	9.72 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.72 kB	9.72 kB	✓
pages-turbo...prod.js gzip	22 kB	22 kB	✓
pages.runtim...dev.js gzip	31.6 kB	31.6 kB	✓
pages.runtim..prod.js gzip	22 kB	22 kB	✓
server.runti..prod.js gzip	61.2 kB	61.2 kB	✓
Overall change	900 kB	900 kB	✓

build cache

	vercel/next.js canary	vercel/next.js sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling	Change
0.pack gzip	2.12 MB	2.11 MB	N/A
index.pack gzip	77.2 kB	77.1 kB	N/A
Overall change	0 B	0 B	✓

Diff details

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: 2b9cecf

eps1lon · 2025-02-11T16:35:09Z

packages/next/src/client/components/react-dev-overlay/server/middleware-webpack.ts

-      if (shouldIgnorePath(formattedFilePath)) {
-        ignoreList.push(index)
-      }
-    }


This was unused. It moved into getIgnoredSources a while ago.

ijjk · 2025-02-12T08:49:22Z

Tests Passed

eps1lon · 2025-02-13T14:12:58Z

Merge activity

Feb 13, 3:12 PM GMT+1: A user merged this pull request with Graphite.

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 10, 2025

eps1lon mentioned this pull request Feb 10, 2025

webpack: Sourcemap externals when replayed in the browser #75863

Merged

eps1lon mentioned this pull request Feb 10, 2025

Create unique source URLs between Client and Server in Pages dir #75878

Merged

eps1lon force-pushed the sebbie/02-10-create_unique_source_urls_between_client_and_server_in_pages_dir branch from c0ee52c to 75a5bc8 Compare February 10, 2025 22:02

eps1lon force-pushed the sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling branch from d2e0086 to 642db76 Compare February 11, 2025 15:01

eps1lon force-pushed the sebbie/02-10-create_unique_source_urls_between_client_and_server_in_pages_dir branch from 75a5bc8 to 3f83cbd Compare February 11, 2025 15:01

eps1lon commented Feb 11, 2025

View reviewed changes

eps1lon force-pushed the sebbie/02-10-create_unique_source_urls_between_client_and_server_in_pages_dir branch from 3f83cbd to 9134ad5 Compare February 11, 2025 18:41

eps1lon force-pushed the sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling branch from 642db76 to 9f552f5 Compare February 11, 2025 18:41

eps1lon mentioned this pull request Feb 11, 2025

Use resource to detect feature usage in telemetry #75917

Merged

eps1lon changed the base branch from sebbie/02-10-create_unique_source_urls_between_client_and_server_in_pages_dir to graphite-base/75879 February 11, 2025 19:15

eps1lon force-pushed the graphite-base/75879 branch from 9134ad5 to 6b92e52 Compare February 12, 2025 06:16

eps1lon force-pushed the sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling branch from 9f552f5 to 0111af7 Compare February 12, 2025 06:16

eps1lon added the CI Bypass Graphite Optimization Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci label Feb 12, 2025

eps1lon force-pushed the sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling branch from 0111af7 to 8357e2c Compare February 12, 2025 08:26

eps1lon force-pushed the graphite-base/75879 branch from 6b92e52 to 5bb8a9b Compare February 12, 2025 08:26

eps1lon force-pushed the graphite-base/75879 branch from 5bb8a9b to 970903e Compare February 12, 2025 08:57

eps1lon force-pushed the sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling branch from 8357e2c to 853feb0 Compare February 12, 2025 08:57

eps1lon mentioned this pull request Feb 12, 2025

Add (failing) test for module based feature telemetry in App Router #75952

Merged

eps1lon removed the CI Bypass Graphite Optimization Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci label Feb 12, 2025

eps1lon force-pushed the sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling branch from 853feb0 to 9d0b3ca Compare February 12, 2025 10:20

eps1lon force-pushed the graphite-base/75879 branch from 970903e to 987179b Compare February 12, 2025 10:20

eps1lon marked this pull request as ready for review February 12, 2025 11:43

eps1lon requested review from huozhi and gaojude February 12, 2025 11:43

eps1lon force-pushed the sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling branch from 9d0b3ca to a88e242 Compare February 12, 2025 16:23

eps1lon force-pushed the graphite-base/75879 branch from 09cf793 to 03c0d1d Compare February 12, 2025 17:31

eps1lon force-pushed the sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling branch from a88e242 to 6e889f8 Compare February 12, 2025 17:31

eps1lon changed the base branch from graphite-base/75879 to sebbie/02-10-create_unique_source_urls_between_client_and_server_in_pages_dir February 12, 2025 17:32

eps1lon force-pushed the sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling branch from 6e889f8 to 14334f7 Compare February 12, 2025 17:32

eps1lon force-pushed the sebbie/02-10-create_unique_source_urls_between_client_and_server_in_pages_dir branch from 03c0d1d to a935156 Compare February 12, 2025 17:40

eps1lon force-pushed the sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling branch from 14334f7 to 2c166e5 Compare February 12, 2025 17:40

eps1lon force-pushed the sebbie/02-10-create_unique_source_urls_between_client_and_server_in_pages_dir branch 2 times, most recently from c1265c5 to 7bf8676 Compare February 12, 2025 19:53

eps1lon force-pushed the sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling branch from 2c166e5 to 0bd70b7 Compare February 12, 2025 19:53

eps1lon changed the base branch from sebbie/02-10-create_unique_source_urls_between_client_and_server_in_pages_dir to graphite-base/75879 February 12, 2025 20:44

eps1lon force-pushed the graphite-base/75879 branch from 7bf8676 to 57c8d04 Compare February 12, 2025 20:45

eps1lon force-pushed the sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling branch from 0bd70b7 to 8e06e42 Compare February 12, 2025 20:45

eps1lon changed the base branch from graphite-base/75879 to canary February 12, 2025 20:45

Cleanup webpack sourcemap middleware source URL handling

2b9cecf

eps1lon force-pushed the sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling branch from 8e06e42 to 2b9cecf Compare February 12, 2025 20:45

huozhi approved these changes Feb 12, 2025

View reviewed changes

eps1lon merged commit bab2f50 into canary Feb 13, 2025
131 checks passed

eps1lon deleted the sebbie/02-10-cleanup_webpack_sourcemap_middleware_source_url_handling branch February 13, 2025 14:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup webpack sourcemap middleware source URL handling #75879

Cleanup webpack sourcemap middleware source URL handling #75879

eps1lon commented Feb 10, 2025 •

edited

Loading

eps1lon commented Feb 10, 2025 •

edited

Loading

ijjk commented Feb 10, 2025 •

edited

Loading

eps1lon Feb 11, 2025

ijjk commented Feb 12, 2025 •

edited

Loading

eps1lon commented Feb 13, 2025

Cleanup webpack sourcemap middleware source URL handling #75879

Cleanup webpack sourcemap middleware source URL handling #75879

Conversation

eps1lon commented Feb 10, 2025 • edited Loading

eps1lon commented Feb 10, 2025 • edited Loading

ijjk commented Feb 10, 2025 • edited Loading

Stats from current PR

eps1lon Feb 11, 2025

Choose a reason for hiding this comment

ijjk commented Feb 12, 2025 • edited Loading

Tests Passed

eps1lon commented Feb 13, 2025

Merge activity

eps1lon commented Feb 10, 2025 •

edited

Loading

eps1lon commented Feb 10, 2025 •

edited

Loading

ijjk commented Feb 10, 2025 •

edited

Loading

ijjk commented Feb 12, 2025 •

edited

Loading