Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: remove next-env.d.ts files #73673

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

JamBalaya56562
Copy link
Contributor

@JamBalaya56562 JamBalaya56562 commented Dec 9, 2024

Summary

Remove next-env.d.ts file from the examples directory because gitignore template includes them.

Description

At #41041, removed next-env.d.ts files.
However, #47241 reintroduced them.

create-next-app makes next-env.d.ts file in the example directory if it's typescript.

// Copy `next-env.d.ts` to any example that is typescript
const tsconfigPath = join(root, 'tsconfig.json')
if (existsSync(tsconfigPath)) {
copyFileSync(
getTemplateFile({ template, mode: 'ts', file: 'next-env.d.ts' }),
join(root, 'next-env.d.ts')
)
}

Therefore, next-env.d.ts file isn't necessary.

CC: @samcx

Adding or Updating Examples

@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 9, 2024
@ijjk
Copy link
Member

ijjk commented Dec 9, 2024

Allow CI Workflow Run

  • approve CI run for commit: 8bdefc1

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@JamBalaya56562 JamBalaya56562 force-pushed the next-env branch 2 times, most recently from 817f4bf to c6c8912 Compare December 9, 2024 02:43
@ijjk ijjk enabled auto-merge (squash) December 9, 2024 04:03
auto-merge was automatically disabled December 9, 2024 04:44

Head branch was pushed to by a user without write access

@JamBalaya56562
Copy link
Contributor Author

Thank you for approving this PR!

CI was failed because some .gitignore files didn't include next-env.d.ts.
I updated them and ran pnpm lint-no-typescript && pnpm check-examples without any errors.

So could you run CI one more time?

@ijjk ijjk enabled auto-merge (squash) December 9, 2024 06:35
@ijjk ijjk merged commit e9c4a75 into vercel:canary Dec 9, 2024
39 checks passed
@JamBalaya56562 JamBalaya56562 deleted the next-env branch December 9, 2024 09:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants