Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: split basic HMR test into multiple files #73616

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Dec 6, 2024

Why?

This PR splits describe.each into separate files:

describe.each([
  { basePath: '', assetPrefix: '' },
  { basePath: '', assetPrefix: '/asset-prefix' },
  { basePath: '/docs', assetPrefix: '' },
  { basePath: '/docs', assetPrefix: '/asset-prefix' },
])

@ijjk
Copy link
Member

ijjk commented Dec 6, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
buildDuration 20.8s 19s N/A
buildDurationCached 18s 15.8s N/A
nodeModulesSize 409 MB 409 MB N/A
nextStartRea..uration (ms) 492ms 491ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
1187-HASH.js gzip 50.2 kB 50.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 33.8 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
_buildManifest.js gzip 747 B 745 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
index.html gzip 524 B 524 B
link.html gzip 539 B 539 B
withRouter.html gzip 520 B 521 B N/A
Overall change 1.06 kB 1.06 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
middleware-b..fest.js gzip 670 B 669 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31 kB 31 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 322 kB 322 kB
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 312 kB 312 kB
app-page.run..prod.js gzip 122 kB 122 kB
app-route-ex...dev.js gzip 37.1 kB 37.1 kB
app-route-ex..prod.js gzip 25.1 kB 25.1 kB
app-route-tu..prod.js gzip 25.1 kB 25.1 kB
app-route-tu..prod.js gzip 24.9 kB 24.9 kB
app-route.ru...dev.js gzip 38.7 kB 38.7 kB
app-route.ru..prod.js gzip 24.9 kB 24.9 kB
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB
pages-turbo...prod.js gzip 21.3 kB 21.3 kB
pages.runtim...dev.js gzip 27 kB 27 kB
pages.runtim..prod.js gzip 21.3 kB 21.3 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.35 MB 2.35 MB
build cache
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
0.pack gzip 2.04 MB 2.04 MB N/A
index.pack gzip 145 kB 144 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: be6a3c5

@devjiwonchoi devjiwonchoi force-pushed the 12-07-test_move_hmr_fixtures_to_a_fixtures__directory branch from babeb23 to 352a8fe Compare December 9, 2024 22:47
@devjiwonchoi devjiwonchoi force-pushed the 12-07-test_split_basic_hmr_test_into_multiple_files branch from ea304a9 to 2d5c033 Compare December 9, 2024 22:59
@ijjk ijjk added the Turbopack Related to Turbopack with Next.js. label Dec 9, 2024
@devjiwonchoi devjiwonchoi changed the base branch from 12-07-test_move_hmr_fixtures_to_a_fixtures__directory to canary December 9, 2024 23:09
@devjiwonchoi devjiwonchoi force-pushed the 12-07-test_split_basic_hmr_test_into_multiple_files branch from 2d5c033 to 5dc5ef0 Compare December 9, 2024 23:12
@devjiwonchoi devjiwonchoi force-pushed the 12-07-test_split_basic_hmr_test_into_multiple_files branch from 5dc5ef0 to be6a3c5 Compare December 9, 2024 23:15
@devjiwonchoi devjiwonchoi enabled auto-merge (squash) December 9, 2024 23:20
@ijjk
Copy link
Member

ijjk commented Dec 9, 2024

Failing test suites

Commit: be6a3c5

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/development/app-hmr/hmr.test.ts (PPR)

  • app-dir-hmr > filesystem changes > should update server components after navigating to a page with a different runtime
Expand output

● app-dir-hmr › filesystem changes › should update server components after navigating to a page with a different runtime

expect(received).toBe(expected) // Object.is equality

Expected: "ipad"
Received: "mac"

  69 |
  70 |         await retry(async () => {
> 71 |           expect(await browser.elementByCss('p').text()).toBe('ipad')
     |                                                          ^
  72 |         })
  73 |
  74 |         const logs = await browser.log()

  at toBe (development/app-hmr/hmr.test.ts:71:58)
  at retry (lib/next-test-utils.ts:806:14)
  at development/app-hmr/hmr.test.ts:70:9
  at NextDevInstance.patchFile (lib/next-modes/base.ts:531:9)
  at NextDevInstance.patchFile (lib/next-modes/next-dev.ts:195:16)
  at Object.<anonymous> (development/app-hmr/hmr.test.ts:67:7)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/prefetching-not-found/prefetching-not-found.test.ts

  • prefetching-not-found > should correctly navigate to/from a global 404 page when following links with prefetch=auto
Expand output

● prefetching-not-found › should correctly navigate to/from a global 404 page when following links with prefetch=auto

expect(received).toContain(expected) // indexOf

Expected substring: "This page could not be found."
Received string:    "Link to `/`
Home Page
Go to Invalid Page"

  14 |
  15 |     await retry(async () => {
> 16 |       expect(await browser.elementByCss('body').text()).toContain(
     |                                                         ^
  17 |         'This page could not be found.'
  18 |       )
  19 |     })

  at toContain (e2e/app-dir/prefetching-not-found/prefetching-not-found.test.ts:16:57)
  at retry (lib/next-test-utils.ts:806:14)
  at Object.<anonymous> (e2e/app-dir/prefetching-not-found/prefetching-not-found.test.ts:15:5)

Read more about building and testing Next.js in contributing.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js team PRs by the Next.js team. tests Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants