Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: split basic HMR test into multiple files #73616

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Dec 6, 2024

Why?

This PR splits describe.each into separate files:

describe.each([
  { basePath: '', assetPrefix: '' },
  { basePath: '', assetPrefix: '/asset-prefix' },
  { basePath: '/docs', assetPrefix: '' },
  { basePath: '/docs', assetPrefix: '/asset-prefix' },
])

@ijjk
Copy link
Member

ijjk commented Dec 6, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
buildDuration 18.9s 15.9s N/A
buildDurationCached 15.2s 12.8s N/A
nodeModulesSize 416 MB 416 MB
nextStartRea..uration (ms) 478ms 475ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 52.8 kB 52.8 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 536 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
middleware-b..fest.js gzip 670 B 665 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 359 kB 359 kB
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 137 kB 137 kB
app-page.run...dev.js gzip 347 kB 347 kB
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.44 MB 2.44 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-07-test_split_basic_hmr_test_into_multiple_files Change
0.pack gzip 2.08 MB 2.08 MB N/A
index.pack gzip 74 kB 75.2 kB ⚠️ +1.2 kB
Overall change 74 kB 75.2 kB ⚠️ +1.2 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 9283716

@devjiwonchoi devjiwonchoi force-pushed the 12-07-test_move_hmr_fixtures_to_a_fixtures__directory branch from babeb23 to 352a8fe Compare December 9, 2024 22:47
@devjiwonchoi devjiwonchoi force-pushed the 12-07-test_split_basic_hmr_test_into_multiple_files branch from ea304a9 to 2d5c033 Compare December 9, 2024 22:59
@ijjk ijjk added the Turbopack Related to Turbopack with Next.js. label Dec 9, 2024
@devjiwonchoi devjiwonchoi changed the base branch from 12-07-test_move_hmr_fixtures_to_a_fixtures__directory to canary December 9, 2024 23:09
@devjiwonchoi devjiwonchoi force-pushed the 12-07-test_split_basic_hmr_test_into_multiple_files branch 2 times, most recently from 5dc5ef0 to be6a3c5 Compare December 9, 2024 23:15
@devjiwonchoi devjiwonchoi enabled auto-merge (squash) December 9, 2024 23:20
@ijjk
Copy link
Member

ijjk commented Dec 9, 2024

Failing test suites

Commit: 9283716

pnpm test-start test/production/graceful-shutdown/index.test.ts

  • Graceful Shutdown > production (standalone mode) > should not accept new requests during shutdown cleanup > when there is no activity
Expand output

● Graceful Shutdown › production (standalone mode) › should not accept new requests during shutdown cleanup › when there is no activity

expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Array [
-   0,
    null,
+   "SIGTERM",
  ]

  233 |
  234 |         // App finally shuts down
> 235 |         expect(await appKilledPromise).toEqual([0, null])
      |                                        ^
  236 |         expect(app.exitCode).toBe(0)
  237 |       })
  238 |     })

  at Object.toEqual (production/graceful-shutdown/index.test.ts:235:40)

Read more about building and testing Next.js in contributing.md.

@devjiwonchoi devjiwonchoi force-pushed the 12-07-test_split_basic_hmr_test_into_multiple_files branch from be6a3c5 to 9283716 Compare December 25, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js team PRs by the Next.js team. tests Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants