Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignore for anonymous stack frame #73610

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Dec 6, 2024

What

We previously filter out the stack frame where the location is <anonymous>. Since the new ignored-list concept introduced, we don't want to filter it out by default as it's also useful in some case. At least we don't hide them for now.

This PR removes the special handling and formatting on error overlay for <anonymous> stack frames.

Closes NDX-544

Copy link
Member Author

huozhi commented Dec 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Dec 6, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 6, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js 12-06-remove_filter_of_anonymous Change
buildDuration 22.5s 20.2s N/A
buildDurationCached 19.1s 16.8s N/A
nodeModulesSize 409 MB 409 MB N/A
nextStartRea..uration (ms) 503ms 504ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-06-remove_filter_of_anonymous Change
1187-HASH.js gzip 50.1 kB 50.1 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 231 B 235 B N/A
main-HASH.js gzip 33.7 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-06-remove_filter_of_anonymous Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 12-06-remove_filter_of_anonymous Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.75 kB 1.75 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 12-06-remove_filter_of_anonymous Change
_buildManifest.js gzip 746 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-06-remove_filter_of_anonymous Change
index.html gzip 523 B 524 B N/A
link.html gzip 537 B 537 B
withRouter.html gzip 519 B 521 B N/A
Overall change 537 B 537 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-06-remove_filter_of_anonymous Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 202 kB 202 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 12-06-remove_filter_of_anonymous Change
middleware-b..fest.js gzip 668 B 664 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.1 kB 31.1 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 12-06-remove_filter_of_anonymous Change
797-experime...dev.js gzip 322 B 322 B
797.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 322 kB 322 kB N/A
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 312 kB 312 kB N/A
app-page.run..prod.js gzip 122 kB 122 kB
app-route-ex...dev.js gzip 36.8 kB 36.8 kB
app-route-ex..prod.js gzip 25 kB 25 kB
app-route-tu..prod.js gzip 25 kB 25 kB
app-route-tu..prod.js gzip 24.8 kB 24.8 kB
app-route.ru...dev.js gzip 38.5 kB 38.5 kB
app-route.ru..prod.js gzip 24.8 kB 24.8 kB
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB
pages-turbo...prod.js gzip 21.3 kB 21.3 kB
pages.runtim...dev.js gzip 27 kB 27 kB
pages.runtim..prod.js gzip 21.3 kB 21.3 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.71 MB 1.71 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-06-remove_filter_of_anonymous Change
0.pack gzip 2.04 MB 2.04 MB ⚠️ +1.2 kB
index.pack gzip 146 kB 145 kB N/A
Overall change 2.04 MB 2.04 MB ⚠️ +1.2 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: 778bc79

@vercel vercel deleted a comment from ijjk Dec 6, 2024
@huozhi huozhi force-pushed the 12-06-remove_filter_of_anonymous branch from 21f8ab5 to 778bc79 Compare December 6, 2024 19:28
@huozhi huozhi marked this pull request as ready for review December 6, 2024 19:52
@huozhi huozhi requested a review from eps1lon December 6, 2024 19:52
@huozhi huozhi merged commit 74b09dd into canary Dec 9, 2024
112 checks passed
@huozhi huozhi deleted the 12-06-remove_filter_of_anonymous branch December 9, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants