Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(composition-patterns): add missing React.ReactNode type in layout.tsx example #73577

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

yeeed711
Copy link
Contributor

@yeeed711 yeeed711 commented Dec 6, 2024

Hi Team,

Added missing children: React.ReactNode type annotation in the TSX version of the Root Layout example to ensure type consistency between JSX and TSX examples in the documentation.

Thank you.

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Dec 6, 2024
@ijjk
Copy link
Member

ijjk commented Dec 6, 2024

Allow CI Workflow Run

  • approve CI run for commit: e00bfa9

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@eps1lon eps1lon merged commit 1718d73 into vercel:canary Dec 6, 2024
40 checks passed
devjiwonchoi pushed a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants