Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Cache] Add isPartial to segment prefetch #73528

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

acdlite
Copy link
Contributor

@acdlite acdlite commented Dec 4, 2024

Based on


During a navigation, we should be able to skip the dynamic request if the prefetched data does not contain any dynamic holes. In the previous cache implementation, we only tracked this per route; in the Segment Cache, we must track this per segment.

This updates the SegmentCacheEntry and CacheNodeSeedData types to include an isPartial field. The field is always false during a dynamic render, or when PPR is disabled.

This PR does not change any behavior; it only adds the new field.

@ijjk
Copy link
Member

ijjk commented Dec 4, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary acdlite/next.js is-partial-segment Change
buildDuration 24s 20.3s N/A
buildDurationCached 19.5s 16.8s N/A
nodeModulesSize 409 MB 409 MB ⚠️ +42.1 kB
nextStartRea..uration (ms) 516ms 507ms N/A
Client Bundles (main, webpack)
vercel/next.js canary acdlite/next.js is-partial-segment Change
1187-HASH.js gzip 50.1 kB 50.1 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 33.7 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary acdlite/next.js is-partial-segment Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary acdlite/next.js is-partial-segment Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.75 kB 1.75 kB
Client Build Manifests
vercel/next.js canary acdlite/next.js is-partial-segment Change
_buildManifest.js gzip 746 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary acdlite/next.js is-partial-segment Change
index.html gzip 523 B 524 B N/A
link.html gzip 537 B 537 B
withRouter.html gzip 519 B 521 B N/A
Overall change 537 B 537 B
Edge SSR bundle Size
vercel/next.js canary acdlite/next.js is-partial-segment Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 202 kB 202 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary acdlite/next.js is-partial-segment Change
middleware-b..fest.js gzip 666 B 664 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.1 kB 31.1 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary acdlite/next.js is-partial-segment Change
797-experime...dev.js gzip 322 B 322 B
797.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 322 kB 322 kB N/A
app-page-exp..prod.js gzip 126 kB 127 kB N/A
app-page-tur..prod.js gzip 139 kB 139 kB N/A
app-page-tur..prod.js gzip 135 kB 135 kB N/A
app-page.run...dev.js gzip 312 kB 312 kB N/A
app-page.run..prod.js gzip 122 kB 122 kB N/A
app-route-ex...dev.js gzip 36.8 kB 36.8 kB
app-route-ex..prod.js gzip 25 kB 25 kB
app-route-tu..prod.js gzip 25 kB 25 kB
app-route-tu..prod.js gzip 24.8 kB 24.8 kB
app-route.ru...dev.js gzip 38.5 kB 38.5 kB
app-route.ru..prod.js gzip 24.8 kB 24.8 kB
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB
pages-turbo...prod.js gzip 21.3 kB 21.3 kB
pages.runtim...dev.js gzip 27 kB 27 kB
pages.runtim..prod.js gzip 21.3 kB 21.3 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.19 MB 1.19 MB
build cache Overall increase ⚠️
vercel/next.js canary acdlite/next.js is-partial-segment Change
0.pack gzip 2.04 MB 2.04 MB ⚠️ +2.55 kB
index.pack gzip 145 kB 146 kB ⚠️ +906 B
Overall change 2.18 MB 2.19 MB ⚠️ +3.46 kB
Diff details
Diff for 1187-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: 75f0518

next.prev = prev
}
} else {
// Already deleted
Copy link

@youneshenniwrites youneshenniwrites Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this else block at the end is redundant and can be removed since it doesn't perform any operations. Will this be more concise?

if (next !== null && prev !== null) {
    lruSize -= deleted.size;

    deleted.next = null;
    deleted.prev = null;

    // Remove from the list
    if (head === deleted) {
        // Update the head
        head = next === head ? null : next;
    } else {
        prev.next = next;
        next.prev = prev;
    }
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acdlite let me know what you think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just there for the comment. It gets stripped out by the minifier.

@acdlite acdlite force-pushed the is-partial-segment branch from 0153d75 to e531497 Compare December 6, 2024 16:36
@ijjk
Copy link
Member

ijjk commented Dec 6, 2024

Tests Passed

During a navigation, we should be able to skip the dynamic request if
the prefetched data does not contain any dynamic holes. In the previous
cache implementation, we only tracked this per route; in the Segment
Cache, we must track this per segment.

This updates the SegmentCacheEntry and CacheNodeSeedData types to
include an `isPartial` field. The field is always false during a dynamic
render, or when PPR is disabled.

No behavior changes are included in this PR.
@acdlite acdlite force-pushed the is-partial-segment branch from e531497 to 75f0518 Compare December 6, 2024 18:15
@acdlite acdlite merged commit d895a7c into vercel:canary Dec 6, 2024
86 checks passed
acdlite added a commit that referenced this pull request Dec 6, 2024
Based on:

- #73434
- #73486 
- #73528

---

Similar to #73528, but for the head, which is delivered separately from
the segments. We can only skip the dynamic request if this value is
`false`.
devjiwonchoi pushed a commit that referenced this pull request Dec 9, 2024
Based on

- #73434
- #73486 

---


During a navigation, we should be able to skip the dynamic request if
the prefetched data does not contain any dynamic holes. In the previous
cache implementation, we only tracked this per route; in the Segment
Cache, we must track this per segment.

This updates the SegmentCacheEntry and CacheNodeSeedData types to
include an `isPartial` field. The field is always false during a dynamic
render, or when PPR is disabled.

This PR does not change any behavior; it only adds the new field.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants