Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Turbopack] fix mmap advise on windows #73462

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[Turbopack] fix mmap advise on windows #73462

merged 1 commit into from
Dec 3, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Dec 3, 2024 •
edited by padmaia
Loading

What?

The import is only available on unix and windows will fail to compile

Closes PACK-3596

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Dec 3, 2024
@sokra sokra changed the title fix mmap advise on windows [Turbopack] fix mmap advise on windows Dec 3, 2024
@sokra Graphite App
Copy link
Member Author

sokra commented Dec 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra requested a review from mischnic December 3, 2024 07:11
@sokra sokra marked this pull request as ready for review December 3, 2024 07:11
@sokra sokra merged commit f95da29 into canary Dec 3, 2024
107 of 113 checks passed
@sokra Graphite App
Copy link
Member Author

sokra commented Dec 3, 2024

Merge activity

  • Dec 3, 2:58 AM EST: A user merged this pull request with Graphite.

@sokra sokra deleted the sokra/windows-mmap branch December 3, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischnic mischnic mischnic approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @mischnic @ijjk