Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: remove app-dir in i18n-routing directory name #73453

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

JamBalaya56562
Copy link
Contributor

@JamBalaya56562 JamBalaya56562 commented Dec 3, 2024

What?

  1. Rename app-dir-i18n-routing example i18n-routing.
  2. Rename i18n-routing example i18n-routing-pages.
  3. Update the docs mentions i18n-routing examples.
  4. Update the test includes i18n-routing examples.

Why?

The default has already been App Router anyways and a lot of examples have migrated over.
x-ref: #72642 (comment)

How?

Change them as in reproduction-template and reproduction-template-pages examples.

Improving Documentation

Adding or Updating Examples

@ijjk ijjk added Documentation Related to Next.js' official documentation. examples Issue was opened via the examples template. tests labels Dec 3, 2024
@ijjk
Copy link
Member

ijjk commented Dec 3, 2024

Allow CI Workflow Run

  • approve CI run for commit: 41c6060

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@delbaoliveira delbaoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty! FYI @samcx

@delbaoliveira delbaoliveira merged commit 4ed2815 into vercel:canary Dec 3, 2024
85 of 86 checks passed
@JamBalaya56562 JamBalaya56562 deleted the i18n branch December 3, 2024 23:45
@MonstraG
Copy link
Contributor

MonstraG commented Dec 6, 2024

Forgot to update docs:
https://nextjs.org/docs/app/building-your-application/routing/internationalization

still links to app-dir-i18n-routing

@JamBalaya56562
Copy link
Contributor Author

Forgot to update docs: https://nextjs.org/docs/app/building-your-application/routing/internationalization

still links to app-dir-i18n-routing

Thank you for your checking!
Yeah, v15.0.4 stable document has an old link.

However, the canary documentation shows the correct new link.

In conclusion, I didn't forget to update the internationalization document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation. examples Issue was opened via the examples template. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants