Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated with-ionic-typescript example to utilize the App Router. #73418

Merged
merged 25 commits into from
Dec 10, 2024

Conversation

PapatMayuri
Copy link
Contributor

This PR updates the with-ionic-typescript example for using the App Router.
Here are the changes that have been made:

  • I renamed the pages folder and moved it to the app folder.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

CC: @samcx

@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 2, 2024
@PapatMayuri PapatMayuri marked this pull request as ready for review December 2, 2024 09:17
@ijjk
Copy link
Member

ijjk commented Dec 2, 2024

Allow CI Workflow Run

  • approve CI run for commit: 7824cd6

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

socket-security bot commented Dec 2, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ionic/[email protected] None +1 42.2 MB ionicjs
npm/[email protected] None +1 27.2 MB ionicjs

🚮 Removed packages: npm/@ionic/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@samcx samcx self-requested a review December 3, 2024 04:42
@samcx
Copy link
Member

samcx commented Dec 3, 2024

@PapatMayuri Let's update this one like this → https://github.com/mlynch/nextjs-tailwind-ionic-capacitor-starter, minus the mobile stuff.

@PapatMayuri
Copy link
Contributor Author

@samcx Updated the PR please check.

@samcx
Copy link
Member

samcx commented Dec 6, 2024

@PapatMayuri Can we make sure we're not importing the same CSS twice?

@PapatMayuri
Copy link
Contributor Author

@samcx Changes done please check

@ijjk ijjk added the tests label Dec 9, 2024
@samcx samcx enabled auto-merge (squash) December 9, 2024 21:05
@ijjk
Copy link
Member

ijjk commented Dec 9, 2024

Failing test suites

Commit: 2a1d354

pnpm test-dev test/development/acceptance-app/ReactRefreshLogBox.test.ts

  • ReactRefreshLogBox app default > server component can recover from error thrown in the module
Expand output

● ReactRefreshLogBox app default › server component can recover from error thrown in the module

Expected Redbox but found none

  1060 |
  1061 |       await next.patchFile('index.js', "throw new Error('module error')")
> 1062 |       await session.assertHasRedbox()
       |       ^
  1063 |       await next.patchFile(
  1064 |         'index.js',
  1065 |         'export default function Page() {return <p>hello world</p>}'

  at Object.<anonymous> (development/acceptance-app/ReactRefreshLogBox.test.ts:1062:7)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/actions/app-action.test.ts

  • app-dir action handling > should forward action request to a worker that contains the action handler (edge)
Expand output

● app-dir action handling › should forward action request to a worker that contains the action handler (edge)

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#other-page')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at e2e/app-dir/actions/app-action.test.ts:862:7

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/development/middleware-errors/index.test.ts

  • middleware - development errors > when middleware throws synchronously > renders the error correctly and recovers
  • middleware - development errors > when running invalid dynamic code with eval > renders the error correctly and recovers
  • middleware - development errors > when throwing while loading the module > renders the error correctly and recovers
Expand output

● middleware - development errors › when middleware throws synchronously › renders the error correctly and recovers

Expected no Redbox but found one
header: 1 of 1 error
Next.js (15.0.4-canary.49)
Server Error

Error: boom

This error happened while generating the page. Any console logs will be displayed in the terminal window.
description: Error: boom
source: middleware.js (3:15) @ default

  1 |
  2 |       export default function () {
> 3 |         throw new Error('boom')
    |               ^
  4 |       }

  59 |       await assertHasRedbox(browser)
  60 |       await next.patchFile('middleware.js', `export default function () {}`)
> 61 |       await assertNoRedbox(browser)
     |       ^
  62 |     })
  63 |   })
  64 |

  at Object.<anonymous> (development/middleware-errors/index.test.ts:61:7)

● middleware - development errors › when running invalid dynamic code with eval › renders the error correctly and recovers

Expected no Redbox but found one
header: 1 of 1 error
Next.js (15.0.4-canary.49)
Server Error

ReferenceError: test is not defined

This error happened while generating the page. Any console logs will be displayed in the terminal window.
description: ReferenceError: test is not defined
source: middleware.js (4:9) @ eval

  2 |       import { NextResponse } from 'next/server'
  3 |       export default function () {
> 4 |         eval('test')
    |         ^
  5 |         return NextResponse.next()
  6 |       }

  185 |       }, 10000) // middleware rebuild takes a while in CI
  186 |
> 187 |       await assertNoRedbox(browser)
      |       ^
  188 |     })
  189 |   })
  190 |

  at Object.<anonymous> (development/middleware-errors/index.test.ts:187:7)

● middleware - development errors › when throwing while loading the module › renders the error correctly and recovers

Expected no Redbox but found one
header: 1 of 1 error
Next.js (15.0.4-canary.49)
Server Error

Error: booooom!

This error happened while generating the page. Any console logs will be displayed in the terminal window.
description: Error: booooom!
source: middleware.js (3:13) @ eval

  1 |
  2 |       import { NextResponse } from 'next/server'
> 3 |       throw new Error('booooom!')
    |             ^
  4 |       export default function () {
  5 |         return NextResponse.next()
  6 |       }

  232 |       expect(source).not.toContain('//middleware.js')
  233 |       await next.patchFile('middleware.js', `export default function () {}`)
> 234 |       await assertNoRedbox(browser)
      |       ^
  235 |     })
  236 |   })
  237 |

  at Object.<anonymous> (development/middleware-errors/index.test.ts:234:7)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Dec 9, 2024

Stats from current PR

Default Build
General
vercel/next.js canary PapatMayuri/next.js update_with-ionic-typescript_example Change
buildDuration 30.1s 28.1s N/A
buildDurationCached 28.8s 21s N/A
nodeModulesSize 409 MB 409 MB
nextStartRea..uration (ms) 839ms 623ms N/A
Client Bundles (main, webpack)
vercel/next.js canary PapatMayuri/next.js update_with-ionic-typescript_example Change
1187-HASH.js gzip 50.2 kB 50.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 33.8 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary PapatMayuri/next.js update_with-ionic-typescript_example Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary PapatMayuri/next.js update_with-ionic-typescript_example Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary PapatMayuri/next.js update_with-ionic-typescript_example Change
_buildManifest.js gzip 747 B 745 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary PapatMayuri/next.js update_with-ionic-typescript_example Change
index.html gzip 524 B 523 B N/A
link.html gzip 538 B 538 B
withRouter.html gzip 520 B 520 B
Overall change 1.06 kB 1.06 kB
Edge SSR bundle Size
vercel/next.js canary PapatMayuri/next.js update_with-ionic-typescript_example Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary PapatMayuri/next.js update_with-ionic-typescript_example Change
middleware-b..fest.js gzip 670 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31 kB 31 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary PapatMayuri/next.js update_with-ionic-typescript_example Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 322 kB 322 kB
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 312 kB 312 kB
app-page.run..prod.js gzip 122 kB 122 kB
app-route-ex...dev.js gzip 37.1 kB 37.1 kB
app-route-ex..prod.js gzip 25.1 kB 25.1 kB
app-route-tu..prod.js gzip 25.1 kB 25.1 kB
app-route-tu..prod.js gzip 24.9 kB 24.9 kB
app-route.ru...dev.js gzip 38.7 kB 38.7 kB
app-route.ru..prod.js gzip 24.9 kB 24.9 kB
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB
pages-turbo...prod.js gzip 21.3 kB 21.3 kB
pages.runtim...dev.js gzip 27 kB 27 kB
pages.runtim..prod.js gzip 21.3 kB 21.3 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.35 MB 2.35 MB
build cache
vercel/next.js canary PapatMayuri/next.js update_with-ionic-typescript_example Change
0.pack gzip 2.04 MB 2.03 MB N/A
index.pack gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 2a1d354

@samcx samcx merged commit 95acd8b into vercel:canary Dec 10, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue was opened via the examples template. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants