-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated with-ionic-typescript example to utilize the App Router. #73418
updated with-ionic-typescript example to utilize the App Router. #73418
Conversation
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@ionic/[email protected], npm/[email protected], npm/[email protected] |
@PapatMayuri Let's update this one like this → https://github.com/mlynch/nextjs-tailwind-ionic-capacitor-starter, minus the mobile stuff. |
@samcx Updated the PR please check. |
@PapatMayuri Can we make sure we're not importing the same CSS twice? |
@samcx Changes done please check |
Failing test suitesCommit: 2a1d354
Expand output● ReactRefreshLogBox app default › server component can recover from error thrown in the module
Read more about building and testing Next.js in contributing.md.
Expand output● app-dir action handling › should forward action request to a worker that contains the action handler (edge)
Read more about building and testing Next.js in contributing.md.
Expand output● middleware - development errors › when middleware throws synchronously › renders the error correctly and recovers
● middleware - development errors › when running invalid dynamic code with eval › renders the error correctly and recovers
● middleware - development errors › when throwing while loading the module › renders the error correctly and recovers
Read more about building and testing Next.js in contributing.md. |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for main-HASH.jsDiff too large to display |
This PR updates the with-ionic-typescript example for using the App Router.
Here are the changes that have been made:
pages
folder and moved it to theapp
folder.layout.tsx
file as part of the App Router.package.json
file.CC: @samcx