-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turbopack: migrate server actions to single-graph-traversal #73260
Merged
mischnic
merged 7 commits into
canary
from
mischnic/mischnic/single-traversal-server-actions
Dec 10, 2024
Merged
Turbopack: migrate server actions to single-graph-traversal #73260
mischnic
merged 7 commits into
canary
from
mischnic/mischnic/single-traversal-server-actions
Dec 10, 2024
+207
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Turbopack team
PRs by the Turbopack team.
Turbopack
Related to Turbopack with Next.js.
labels
Nov 27, 2024
mischnic
changed the title
Migrate server actions to single-graph-traversal
Turbopack: migrate server actions to single-graph-traversal
Nov 27, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js mischnic/mischnic/single-traversal-server-actions | Change | |
---|---|---|---|
buildDuration | 20.4s | 17.6s | N/A |
buildDurationCached | 16.8s | 14.7s | N/A |
nodeModulesSize | 409 MB | 409 MB | N/A |
nextStartRea..uration (ms) | 473ms | 478ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js mischnic/mischnic/single-traversal-server-actions | Change | |
---|---|---|---|
1187-HASH.js gzip | 50.2 kB | 50.2 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.3 kB | 5.3 kB | N/A |
bccd1874-HASH.js gzip | 53 kB | 53 kB | N/A |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 232 B | 235 B | N/A |
main-HASH.js gzip | 33.8 kB | 33.7 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js mischnic/mischnic/single-traversal-server-actions | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js mischnic/mischnic/single-traversal-server-actions | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.44 kB | 4.43 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js mischnic/mischnic/single-traversal-server-actions | Change | |
---|---|---|---|
_buildManifest.js gzip | 747 B | 745 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js mischnic/mischnic/single-traversal-server-actions | Change | |
---|---|---|---|
index.html gzip | 524 B | 523 B | N/A |
link.html gzip | 538 B | 538 B | ✓ |
withRouter.html gzip | 520 B | 520 B | ✓ |
Overall change | 1.06 kB | 1.06 kB | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js mischnic/mischnic/single-traversal-server-actions | Change | |
---|---|---|---|
edge-ssr.js gzip | 128 kB | 128 kB | N/A |
page.js gzip | 203 kB | 203 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js mischnic/mischnic/single-traversal-server-actions | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 671 B | 668 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31 kB | 31 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js mischnic/mischnic/single-traversal-server-actions | Change | |
---|---|---|---|
523-experime...dev.js gzip | 322 B | 322 B | ✓ |
523.runtime.dev.js gzip | 314 B | 314 B | ✓ |
app-page-exp...dev.js gzip | 322 kB | 322 kB | ✓ |
app-page-exp..prod.js gzip | 127 kB | 127 kB | ✓ |
app-page-tur..prod.js gzip | 140 kB | 140 kB | ✓ |
app-page-tur..prod.js gzip | 135 kB | 135 kB | ✓ |
app-page.run...dev.js gzip | 312 kB | 312 kB | ✓ |
app-page.run..prod.js gzip | 122 kB | 122 kB | ✓ |
app-route-ex...dev.js gzip | 37.1 kB | 37.1 kB | ✓ |
app-route-ex..prod.js gzip | 25.1 kB | 25.1 kB | ✓ |
app-route-tu..prod.js gzip | 25.1 kB | 25.1 kB | ✓ |
app-route-tu..prod.js gzip | 24.9 kB | 24.9 kB | ✓ |
app-route.ru...dev.js gzip | 38.7 kB | 38.7 kB | ✓ |
app-route.ru..prod.js gzip | 24.9 kB | 24.9 kB | ✓ |
pages-api-tu..prod.js gzip | 9.56 kB | 9.56 kB | ✓ |
pages-api.ru...dev.js gzip | 11.4 kB | 11.4 kB | ✓ |
pages-api.ru..prod.js gzip | 9.56 kB | 9.56 kB | ✓ |
pages-turbo...prod.js gzip | 21.3 kB | 21.3 kB | ✓ |
pages.runtim...dev.js gzip | 27 kB | 27 kB | ✓ |
pages.runtim..prod.js gzip | 21.3 kB | 21.3 kB | ✓ |
server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
Overall change | 2.35 MB | 2.35 MB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js mischnic/mischnic/single-traversal-server-actions | Change | |
---|---|---|---|
0.pack gzip | 2.03 MB | 2.04 MB | |
index.pack gzip | 145 kB | 146 kB | |
Overall change | 2.18 MB | 2.18 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
mischnic
force-pushed
the
mischnic/single-traversal-next-dynamic
branch
from
November 27, 2024 15:44
6fdb3cc
to
9e3c57a
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
November 27, 2024 15:45
6d7bf4e
to
1bc3dd4
Compare
mischnic
force-pushed
the
mischnic/single-traversal-next-dynamic
branch
from
November 28, 2024 09:31
9e3c57a
to
c0a8154
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
2 times, most recently
from
November 28, 2024 10:02
2197248
to
5d56576
Compare
mischnic
force-pushed
the
mischnic/single-traversal-next-dynamic
branch
from
November 28, 2024 11:31
cf9c5d1
to
d140123
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
November 28, 2024 11:31
5d56576
to
176be2c
Compare
mischnic
force-pushed
the
mischnic/single-traversal-next-dynamic
branch
from
November 28, 2024 15:25
d140123
to
0378e72
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
November 28, 2024 15:26
176be2c
to
da8ef0c
Compare
mischnic
force-pushed
the
mischnic/single-traversal-next-dynamic
branch
from
November 28, 2024 17:43
0378e72
to
5ef7079
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
November 28, 2024 17:43
da8ef0c
to
699e475
Compare
mischnic
force-pushed
the
mischnic/single-traversal-next-dynamic
branch
from
November 29, 2024 09:17
5ef7079
to
80506fa
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
November 29, 2024 09:17
699e475
to
356c01e
Compare
mischnic
force-pushed
the
mischnic/single-traversal-next-dynamic
branch
from
December 2, 2024 10:13
80506fa
to
f734299
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
December 2, 2024 10:13
356c01e
to
4860977
Compare
mischnic
force-pushed
the
mischnic/single-traversal-next-dynamic
branch
from
December 3, 2024 12:09
f734299
to
368ff77
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
December 3, 2024 12:10
4860977
to
3fab151
Compare
mischnic
force-pushed
the
mischnic/single-traversal-next-dynamic
branch
2 times, most recently
from
December 3, 2024 15:17
ed32c69
to
d2081b4
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
December 3, 2024 15:17
3fab151
to
e7db9dc
Compare
mischnic
force-pushed
the
mischnic/single-traversal-next-dynamic
branch
from
December 4, 2024 15:26
d2081b4
to
17b6489
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
December 4, 2024 18:46
85864d7
to
f001e9d
Compare
mischnic
force-pushed
the
mischnic/single-traversal-next-dynamic
branch
from
December 5, 2024 12:09
c325524
to
cb05a83
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
December 5, 2024 12:09
f001e9d
to
cecd490
Compare
mischnic
force-pushed
the
mischnic/single-traversal-next-dynamic
branch
from
December 9, 2024 14:58
cb05a83
to
ae17d73
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
December 9, 2024 14:59
cecd490
to
8982f52
Compare
mischnic
force-pushed
the
mischnic/single-traversal-next-dynamic
branch
from
December 9, 2024 21:36
f0514d4
to
75cc7cf
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
December 9, 2024 21:36
8982f52
to
b02bc59
Compare
sokra
reviewed
Dec 10, 2024
sokra
approved these changes
Dec 10, 2024
sokra
added
the
CI Bypass Graphite Optimization
Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci
label
Dec 10, 2024
— with
Graphite App
mischnic
force-pushed
the
mischnic/single-traversal-next-dynamic
branch
from
December 10, 2024 12:14
75cc7cf
to
65d716f
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
December 10, 2024 12:14
b02bc59
to
f1a4784
Compare
mischnic
changed the base branch from
mischnic/single-traversal-next-dynamic
to
graphite-base/73260
December 10, 2024 13:23
mischnic
force-pushed
the
graphite-base/73260
branch
from
December 10, 2024 13:23
65d716f
to
b94dfd0
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
December 10, 2024 13:23
f1a4784
to
79380ce
Compare
mischnic
force-pushed
the
mischnic/mischnic/single-traversal-server-actions
branch
from
December 10, 2024 13:24
79380ce
to
c97aa92
Compare
mischnic
deleted the
mischnic/mischnic/single-traversal-server-actions
branch
December 10, 2024 14:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI Bypass Graphite Optimization
Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci
created-by: Turbopack team
PRs by the Turbopack team.
Turbopack
Related to Turbopack with Next.js.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PACK-3537