Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add the section titles to error page #72942

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

JamBalaya56562
Copy link
Contributor

Summary

Add the paragraph name to next-prerender-crypto error page like other next-prerender pages.

Improving Documentation

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Nov 19, 2024
@ijjk
Copy link
Member

ijjk commented Nov 19, 2024

Allow CI Workflow Run

  • approve CI run for commit: d0addc9

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@delbaoliveira delbaoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, made some action-based suggestions for the headings. I do feel the wording of this error message can be improved overall to make it clearer, but let's start with the headings.

errors/next-prerender-crypto.mdx Outdated Show resolved Hide resolved
errors/next-prerender-crypto.mdx Outdated Show resolved Hide resolved
errors/next-prerender-crypto.mdx Outdated Show resolved Hide resolved
@JamBalaya56562
Copy link
Contributor Author

Hey, made some action-based suggestions for the headings. I do feel the wording of this error message can be improved overall to make it clearer, but let's start with the headings.

Thank you for nice review and good suggestion!
I have applied your requests.

Copy link
Contributor

@delbaoliveira delbaoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@delbaoliveira delbaoliveira merged commit f5ead56 into vercel:canary Nov 19, 2024
39 checks passed
@JamBalaya56562 JamBalaya56562 deleted the title branch November 19, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants