Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples(with-supabase): fix action type error #72783

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

samcx
Copy link
Member

@samcx samcx commented Nov 13, 2024

Why?

There is a type issue with one of the form actions.

app/(auth-pages)/sign-up/page.tsx:42:25 - error TS2322: Type '(formData: FormData) => Promise<{ error: string; }>' is not assignable to type 'string | ((formData: FormData) => void | Promise<void>) | undefined'.
  Type '(formData: FormData) => Promise<{ error: string; }>' is not assignable to type '(formData: FormData) => void | Promise<void>'.
    Type 'Promise<{ error: string; }>' is not assignable to type 'void | Promise<void>'.
      Type 'Promise<{ error: string; }>' is not assignable to type 'Promise<void>'.
        Type '{ error: string; }' is not assignable to type 'void'.

42           <SubmitButton formAction={signUpAction} pendingText="Signing up...">

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. examples Issue was opened via the examples template. labels Nov 13, 2024
Copy link
Member Author

samcx commented Nov 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @samcx and the rest of your teammates on Graphite Graphite

@samcx samcx requested a review from gaojude November 13, 2024 22:12
@samcx samcx marked this pull request as ready for review November 13, 2024 22:12
@samcx samcx changed the title examples(with-supabase): bump packages examples(with-supabase): fix action type error Nov 13, 2024
@samcx samcx merged commit 90cd4e0 into canary Nov 13, 2024
55 checks passed
Copy link
Member Author

samcx commented Nov 13, 2024

Merge activity

  • Nov 13, 5:19 PM EST: A user merged this pull request with Graphite.

@samcx samcx deleted the sam/examples/with-supabase-type-error branch November 13, 2024 22:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants