Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNA: prompt enable turbopack value to true #72616

Merged
merged 1 commit into from
Nov 12, 2024
Merged

CNA: prompt enable turbopack value to true #72616

merged 1 commit into from
Nov 12, 2024

Conversation

devjiwonchoi
Copy link
Member

Why?

Since Turbopack for dev is stable for v15, enable the prompt value to true.

Closes NDX-461
x-ref: slack-thread

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team. labels Nov 12, 2024
@ijjk
Copy link
Member

ijjk commented Nov 12, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js jwn/8zfv Change
buildDuration 19.2s 20.6s ⚠️ +1.4s
buildDurationCached 16.4s 14.6s N/A
nodeModulesSize 402 MB 403 MB ⚠️ +1.01 MB
nextStartRea..uration (ms) 472ms 475ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js jwn/8zfv Change
3073-HASH.js gzip 45.6 kB 45.5 kB N/A
3898-HASH.js gzip 5.27 kB 5.27 kB N/A
7183.HASH.js gzip 169 B 168 B N/A
b5cfd723-HASH.js gzip 52.5 kB 52.5 kB N/A
framework-HASH.js gzip 57.3 kB 57.3 kB N/A
main-app-HASH.js gzip 234 B 232 B N/A
main-HASH.js gzip 33.2 kB 33.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB ✓
Overall change 1.71 kB 1.71 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js jwn/8zfv Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js jwn/8zfv Change
_app-HASH.js gzip 193 B 194 B N/A
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 343 B 344 B N/A
dynamic-HASH.js gzip 1.85 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 392 B 393 B N/A
image-HASH.js gzip 4.41 kB 4.4 kB N/A
index-HASH.js gzip 268 B 266 B N/A
link-HASH.js gzip 2.77 kB 2.78 kB N/A
routerDirect..HASH.js gzip 327 B 325 B N/A
script-HASH.js gzip 396 B 397 B N/A
withRouter-HASH.js gzip 324 B 324 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 887 B 887 B ✓
Client Build Manifests
vercel/next.js canary vercel/next.js jwn/8zfv Change
_buildManifest.js gzip 748 B 748 B ✓
Overall change 748 B 748 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js jwn/8zfv Change
index.html gzip 525 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 519 B 519 B ✓
Overall change 519 B 519 B ✓
Edge SSR bundle Size Overall increase ⚠️
vercel/next.js canary vercel/next.js jwn/8zfv Change
edge-ssr.js gzip 128 kB 128 kB ⚠️ +142 B
page.js gzip 198 kB 198 kB N/A
Overall change 128 kB 128 kB ⚠️ +142 B
Middleware size
vercel/next.js canary vercel/next.js jwn/8zfv Change
middleware-b..fest.js gzip 670 B 667 B N/A
middleware-r..fest.js gzip 156 B 155 B N/A
middleware.js gzip 31 kB 31 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js jwn/8zfv Change
196-experime...dev.js gzip 322 B 322 B ✓
196.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 319 kB 319 kB N/A
app-page-exp..prod.js gzip 123 kB 123 kB ⚠️ +141 B
app-page-tur..prod.js gzip 136 kB 136 kB ⚠️ +133 B
app-page-tur..prod.js gzip 131 kB 131 kB ⚠️ +123 B
app-page.run...dev.js gzip 309 kB 309 kB N/A
app-page.run..prod.js gzip 119 kB 119 kB ⚠️ +117 B
app-route-ex...dev.js gzip 36 kB 36 kB N/A
app-route-ex..prod.js gzip 24.4 kB 24.4 kB N/A
app-route-tu..prod.js gzip 24.4 kB 24.4 kB N/A
app-route-tu..prod.js gzip 24.2 kB 24.2 kB N/A
app-route.ru...dev.js gzip 37.6 kB 37.6 kB N/A
app-route.ru..prod.js gzip 24.2 kB 24.2 kB N/A
pages-api-tu..prod.js gzip 9.59 kB 9.59 kB ✓
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB ✓
pages-api.ru..prod.js gzip 9.58 kB 9.58 kB ✓
pages-turbo...prod.js gzip 20.9 kB 20.9 kB ✓
pages.runtim...dev.js gzip 26.5 kB 26.5 kB ✓
pages.runtim..prod.js gzip 20.9 kB 20.9 kB ✓
server.runti..prod.js gzip 916 kB 915 kB N/A
Overall change 608 kB 608 kB ⚠️ +514 B
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js jwn/8zfv Change
0.pack gzip 2.01 MB 2 MB N/A
index.pack gzip 145 kB 146 kB ⚠️ +117 B
Overall change 145 kB 146 kB ⚠️ +117 B
Diff details
Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for image-HASH.js 
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [2983],
   {
-    /***/ 8916: /***/ (
+    /***/ 7893: /***/ (
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -9,7 +9,7 @@
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/image",
         function () {
-          return __webpack_require__(4209);
+          return __webpack_require__(3231);
         },
       ]);
       if (false) {
@@ -18,7 +18,7 @@
       /***/
     },
 
-    /***/ 9265: /***/ (module, exports, __webpack_require__) => {
+    /***/ 4457: /***/ (module, exports, __webpack_require__) => {
       "use strict";
       /* __next_internal_client_entry_do_not_use__  cjs */
       Object.defineProperty(exports, "__esModule", {
@@ -40,17 +40,17 @@
         __webpack_require__(9577)
       );
       const _head = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(1436)
+        __webpack_require__(5156)
       );
-      const _getimgprops = __webpack_require__(8517);
-      const _imageconfig = __webpack_require__(2168);
-      const _imageconfigcontextsharedruntime = __webpack_require__(9202);
-      const _warnonce = __webpack_require__(6992);
-      const _routercontextsharedruntime = __webpack_require__(8155);
+      const _getimgprops = __webpack_require__(637);
+      const _imageconfig = __webpack_require__(2720);
+      const _imageconfigcontextsharedruntime = __webpack_require__(8650);
+      const _warnonce = __webpack_require__(5752);
+      const _routercontextsharedruntime = __webpack_require__(5139);
       const _imageloader = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(345)
+        __webpack_require__(2801)
       );
-      const _usemergedref = __webpack_require__(2806);
+      const _usemergedref = __webpack_require__(1985);
       // This is replaced by webpack define plugin
       const configEnv = {
         deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
@@ -371,7 +371,7 @@
       /***/
     },
 
-    /***/ 2806: /***/ (module, exports, __webpack_require__) => {
+    /***/ 1985: /***/ (module, exports, __webpack_require__) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -432,7 +432,7 @@
       /***/
     },
 
-    /***/ 8517: /***/ (
+    /***/ 637: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -448,9 +448,9 @@
           return getImgProps;
         },
       });
-      const _warnonce = __webpack_require__(6992);
-      const _imageblursvg = __webpack_require__(1692);
-      const _imageconfig = __webpack_require__(2168);
+      const _warnonce = __webpack_require__(5752);
+      const _imageblursvg = __webpack_require__(1732);
+      const _imageconfig = __webpack_require__(2720);
       const VALID_LOADING_VALUES =
         /* unused pure expression or super */ null && [
           "lazy",
@@ -824,7 +824,7 @@
       /***/
     },
 
-    /***/ 1692: /***/ (__unused_webpack_module, exports) => {
+    /***/ 1732: /***/ (__unused_webpack_module, exports) => {
       "use strict";
       /**
        * A shared function, used on both client and server, to generate a SVG blur placeholder.
@@ -879,7 +879,7 @@
       /***/
     },
 
-    /***/ 4673: /***/ (
+    /***/ 857: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -906,10 +906,10 @@
         },
       });
       const _interop_require_default = __webpack_require__(1739);
-      const _getimgprops = __webpack_require__(8517);
-      const _imagecomponent = __webpack_require__(9265);
+      const _getimgprops = __webpack_require__(637);
+      const _imagecomponent = __webpack_require__(4457);
       const _imageloader = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(345)
+        __webpack_require__(2801)
       );
       function getImageProps(imgProps) {
         const { props } = (0, _getimgprops.getImgProps)(imgProps, {
@@ -941,7 +941,7 @@
       /***/
     },
 
-    /***/ 345: /***/ (__unused_webpack_module, exports) => {
+    /***/ 2801: /***/ (__unused_webpack_module, exports) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -976,7 +976,7 @@
       /***/
     },
 
-    /***/ 4209: /***/ (
+    /***/ 3231: /***/ (
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -993,8 +993,8 @@
 
       // EXTERNAL MODULE: ./node_modules/.pnpm/[email protected]/node_modules/react/jsx-runtime.js
       var jsx_runtime = __webpack_require__(7515);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-7c8e5e7a-20241101_re_ngsqfltlxii45umrwe6rktuauy/node_modules/next/image.js
-      var next_image = __webpack_require__(7265);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-7c8e5e7a-20241101_re_ay5jspqvpcpk5357qiimbatlya/node_modules/next/image.js
+      var next_image = __webpack_require__(3120);
       var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // ./pages/nextjs.png
       /* harmony default export */ const nextjs = {
         src: "/_next/static/media/nextjs.cae0b805.png",
@@ -1024,12 +1024,12 @@
       /***/
     },
 
-    /***/ 7265: /***/ (
+    /***/ 3120: /***/ (
       module,
       __unused_webpack_exports,
       __webpack_require__
     ) => {
-      module.exports = __webpack_require__(4673);
+      module.exports = __webpack_require__(857);
 
       /***/
     },
@@ -1039,7 +1039,7 @@
     /******/ var __webpack_exec__ = (moduleId) =>
       __webpack_require__((__webpack_require__.s = moduleId));
     /******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
-      __webpack_exec__(8916)
+      __webpack_exec__(7893)
     );
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for 3073-HASH.js

Diff too large to display

Diff for b5cfd723-HASH.js 
@@ -1,13 +1,13 @@
 "use strict";
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
-  [4601],
+  [5518],
   {
-    /***/ 6216: /***/ (
+    /***/ 5637: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
     ) => {
-      /* provided dependency */ var process = __webpack_require__(5978);
+      /* provided dependency */ var process = __webpack_require__(231);
       /**
        * @license React
        * react-dom-client.production.js
@@ -22,9 +22,9 @@
  Modernizr 3.0.0pre (Custom Build) | MIT
 */
 
-      var Scheduler = __webpack_require__(987),
-        React = __webpack_require__(8059),
-        ReactDOM = __webpack_require__(5882);
+      var Scheduler = __webpack_require__(976),
+        React = __webpack_require__(4922),
+        ReactDOM = __webpack_require__(8919);
       function formatProdErrorMessage(code) {
         var url = "https://react.dev/errors/" + code;
         if (1 < arguments.length) {
@@ -2825,9 +2825,9 @@
         null === thenableState$1 && (thenableState$1 = []);
         return trackUsedThenable(thenableState$1, thenable, index);
       }
-      function coerceRef(workInProgress, element) {
-        element = element.props.ref;
-        workInProgress.ref = void 0 !== element ? element : null;
+      function coerceRef(returnFiber, current, workInProgress, element) {
+        returnFiber = element.props.ref;
+        workInProgress.ref = void 0 !== returnFiber ? returnFiber : null;
       }
       function throwOnInvalidObjectType(returnFiber, newChild) {
         if (newChild.$$typeof === REACT_LEGACY_ELEMENT_TYPE)
@@ -2935,12 +2935,12 @@
                 resolveLazy(elementType) === current.type))
           )
             return (
-              (current = useFiber(current, element.props)),
-              coerceRef(current, element),
-              (current.return = returnFiber),
-              current
+              (lanes = useFiber(current, element.props)),
+              coerceRef(returnFiber, current, lanes, element),
+              (lanes.return = returnFiber),
+              lanes
             );
-          current = createFiberFromTypeAndProps(
+          lanes = createFiberFromTypeAndProps(
             element.type,
             element.key,
             element.props,
@@ -2948,9 +2948,9 @@
             returnFiber.mode,
             lanes
           );
-          coerceRef(current, element);
-          current.return = returnFiber;
-          return current;
+          coerceRef(returnFiber, current, lanes, element);
+          lanes.return = returnFiber;
+          return lanes;
         }
         function updatePortal(returnFiber, current, portal, lanes) {
           if (
@@ -3015,7 +3015,7 @@
                     returnFiber.mode,
                     lanes
                   )),
-                  coerceRef(lanes, newChild),
+                  coerceRef(returnFiber, null, lanes, newChild),
                   (lanes.return = returnFiber),
                   lanes
                 );
@@ -3387,54 +3387,57 @@
             switch (newChild.$$typeof) {
               case REACT_ELEMENT_TYPE:
                 a: {
-                  for (var key = newChild.key; null !== currentFirstChild; ) {
-                    if (currentFirstChild.key === key) {
+                  for (
+                    var key = newChild.key, child = currentFirstChild;
+                    null !== child;
+
+                  ) {
+                    if (child.key === key) {
                       key = newChild.type;
                       if (key === REACT_FRAGMENT_TYPE) {
-                        if (7 === currentFirstChild.tag) {
-                          deleteRemainingChildren(
-                            returnFiber,
-                            currentFirstChild.sibling
-                          );
-                          lanes = useFiber(
-                            currentFirstChild,
+                        if (7 === child.tag) {
+                          deleteRemainingChildren(returnFiber, child.sibling);
+                          currentFirstChild = useFiber(
+                            child,
                             newChild.props.children
                           );
-                          lanes.return = returnFiber;
-                          returnFiber = lanes;
+                          currentFirstChild.return = returnFiber;
+                          returnFiber = currentFirstChild;
                           break a;
                         }
                       } else if (
-                        currentFirstChild.elementType === key ||
+                        child.elementType === key ||
                         ("object" === typeof key &&
                           null !== key &&
                           key.$$typeof === REACT_LAZY_TYPE &&
-                          resolveLazy(key) === currentFirstChild.type)
+                          resolveLazy(key) === child.type)
                       ) {
-                        deleteRemainingChildren(
+                        deleteRemainingChildren(returnFiber, child.sibling);
+                        currentFirstChild = useFiber(child, newChild.props);
+                        coerceRef(
                           returnFiber,
-                          currentFirstChild.sibling
+                          child,
+                          currentFirstChild,
+                          newChild
                         );
-                        lanes = useFiber(currentFirstChild, newChild.props);
-                        coerceRef(lanes, newChild);
-                        lanes.return = returnFiber;
-                        returnFiber = lanes;
+                        currentFirstChild.return = returnFiber;
+                        returnFiber = currentFirstChild;
                         break a;
                       }
-                      deleteRemainingChildren(returnFiber, currentFirstChild);
+                      deleteRemainingChildren(returnFiber, child);
                       break;
-                    } else deleteChild(returnFiber, currentFirstChild);
-                    currentFirstChild = currentFirstChild.sibling;
+                    } else deleteChild(returnFiber, child);
+                    child = child.sibling;
                   }
                   newChild.type === REACT_FRAGMENT_TYPE
-                    ? ((lanes = createFiberFromFragment(
+                    ? ((currentFirstChild = createFiberFromFragment(
                         newChild.props.children,
                         returnFiber.mode,
                         lanes,
                         newChild.key
                       )),
-                      (lanes.return = returnFiber),
-                      (returnFiber = lanes))
+                      (currentFirstChild.return = returnFiber),
+                      (returnFiber = currentFirstChild))
                     : ((lanes = createFiberFromTypeAndProps(
                         newChild.type,
                         newChild.key,
@@ -3443,15 +3446,20 @@
                         returnFiber.mode,
                         lanes
                       )),
-                      coerceRef(lanes, newChild),
+                      coerceRef(
+                        returnFiber,
+                        currentFirstChild,
+                        lanes,
+                        newChild
+                      ),
                       (lanes.return = returnFiber),
                       (returnFiber = lanes));
                 }
                 return placeSingleChild(returnFiber);
               case REACT_PORTAL_TYPE:
                 a: {
-                  for (key = newChild.key; null !== currentFirstChild; ) {
-                    if (currentFirstChild.key === key)
+                  for (child = newChild.key; null !== currentFirstChild; ) {
+                    if (currentFirstChild.key === child)
                       if (
                         4 === currentFirstChild.tag &&
                         currentFirstChild.stateNode.containerInfo ===
@@ -3463,12 +3471,12 @@
                           returnFiber,
                           currentFirstChild.sibling
                         );
-                        lanes = useFiber(
+                        currentFirstChild = useFiber(
                           currentFirstChild,
                           newChild.children || []
                         );
-                        lanes.return = returnFiber;
-                        returnFiber = lanes;
+                        currentFirstChild.return = returnFiber;
+                        returnFiber = currentFirstChild;
                         break a;
                       } else {
                         deleteRemainingChildren(returnFiber, currentFirstChild);
@@ -3477,19 +3485,19 @@
                     else deleteChild(returnFiber, currentFirstChild);
                     currentFirstChild = currentFirstChild.sibling;
                   }
-                  lanes = createFiberFromPortal(
+                  currentFirstChild = createFiberFromPortal(
                     newChild,
                     returnFiber.mode,
                     lanes
                   );
-                  lanes.return = returnFiber;
-                  returnFiber = lanes;
+                  currentFirstChild.return = returnFiber;
+                  returnFiber = currentFirstChild;
                 }
                 return placeSingleChild(returnFiber);
               case REACT_LAZY_TYPE:
                 return (
-                  (key = newChild._init),
-                  (newChild = key(newChild._payload)),
+                  (child = newChild._init),
+                  (newChild = child(newChild._payload)),
                   reconcileChildFibersImpl(
                     returnFiber,
                     currentFirstChild,
@@ -3506,10 +3514,10 @@
                 lanes
               );
             if (getIteratorFn(newChild)) {
-              key = getIteratorFn(newChild);
-              if ("function" !== typeof key)
+              child = getIteratorFn(newChild);
+              if ("function" !== typeof child)
                 throw Error(formatProdErrorMessage(150));
-              newChild = key.call(newChild);
+              newChild = child.call(newChild);
               return reconcileChildrenIterator(
                 returnFiber,
                 currentFirstChild,
@@ -3542,17 +3550,17 @@
                     returnFiber,
                     currentFirstChild.sibling
                   ),
-                  (lanes = useFiber(currentFirstChild, newChild)),
-                  (lanes.return = returnFiber),
-                  (returnFiber = lanes))
+                  (currentFirstChild = useFiber(currentFirstChild, newChild)),
+                  (currentFirstChild.return = returnFiber),
+                  (returnFiber = currentFirstChild))
                 : (deleteRemainingChildren(returnFiber, currentFirstChild),
-                  (lanes = createFiberFromText(
+                  (currentFirstChild = createFiberFromText(
                     newChild,
                     returnFiber.mode,
                     lanes
                   )),
-                  (lanes.return = returnFiber),
-                  (returnFiber = lanes)),
+                  (currentFirstChild.return = returnFiber),
+                  (returnFiber = currentFirstChild)),
               placeSingleChild(returnFiber))
             : deleteRemainingChildren(returnFiber, currentFirstChild);
         }
@@ -7479,7 +7487,14 @@
       }
       var valueCursor = createCursor(null),
         currentlyRenderingFiber = null,
-        lastContextDependency = null;
+        lastContextDependency = null,
+        lastFullyObservedContext = null;
+      function resetContextDependencies() {
+        lastFullyObservedContext =
+          lastContextDependency =
+          currentlyRenderingFiber =
+            null;
+      }
       function pushProvider(providerFiber, context, nextValue) {
         push(valueCursor, context._currentValue);
         context._currentValue = nextValue;
@@ -7634,7 +7649,7 @@
       }
       function prepareToReadContext(workInProgress) {
         currentlyRenderingFiber = workInProgress;
-        lastContextDependency = null;
+        lastFullyObservedContext = lastContextDependency = null;
         workInProgress = workInProgress.dependencies;
         null !== workInProgress && (workInProgress.firstContext = null);
       }
@@ -7647,13 +7662,16 @@
       }
       function readContextForConsumer(consumer, context) {
         var value = context._currentValue;
-        context = { context: context, memoizedValue: value, next: null };
-        if (null === lastContextDependency) {
-          if (null === consumer) throw Error(formatProdErrorMessage(308));
-          lastContextDependency = context;
-          consumer.dependencies = { lanes: 0, firstContext: context };
-          consumer.flags |= 524288;
-        } else lastContextDependency = lastContextDependency.next = context;
+        if (lastFullyObservedContext !== context)
+          if (
+            ((context = { context: context, memoizedValue: value, next: null }),
+            null === lastContextDependency)
+          ) {
+            if (null === consumer) throw Error(formatProdErrorMessage(308));
+            lastContextDependency = context;
+            consumer.dependencies = { lanes: 0, firstContext: context };
+            consumer.flags |= 524288;
+          } else lastContextDependency = lastContextDependency.next = context;
         return value;
       }
       var hasForceUpdate = !1;
@@ -11203,7 +11221,7 @@
             var interruptedWork = workInProgress.return;
           else
             (interruptedWork = workInProgress),
-              (lastContextDependency = currentlyRenderingFiber = null),
+              resetContextDependencies(),
               resetHooksOnUnwind(interruptedWork),
               (thenableState$1 = null),
               (thenableIndexCounter$1 = 0),
@@ -11370,7 +11388,7 @@
           }
         while (1);
         lanes && root.shellSuspendCounter++;
-        lastContextDependency = currentlyRenderingFiber = null;
+        resetContextDependencies();
         executionContext = prevExecutionContext;
         ReactSharedInternals.H = prevDispatcher;
         ReactSharedInternals.A = prevAsyncDispatcher;
@@ -11485,7 +11503,7 @@
             handleThrow(root, thrownValue$160);
           }
         while (1);
-        lastContextDependency = currentlyRenderingFiber = null;
+        resetContextDependencies();
         ReactSharedInternals.H = prevDispatcher;
         ReactSharedInternals.A = prevAsyncDispatcher;
         executionContext = prevExecutionContext;
@@ -11549,7 +11567,7 @@
           : (workInProgress = next);
       }
       function throwAndUnwindWorkLoop(root, unitOfWork, thrownValue) {
-        lastContextDependency = currentlyRenderingFiber = null;
+        resetContextDependencies();
         resetHooksOnUnwind(unitOfWork);
         thenableState$1 = null;
         thenableIndexCounter$1 = 0;
@@ -15945,14 +15963,14 @@
       };
       var isomorphicReactPackageVersion$jscomp$inline_1676 = React.version;
       if (
-        "19.0.0-rc-5c56b873-20241107" !==
+        "19.0.0-rc-7c8e5e7a-20241101" !==
         isomorphicReactPackageVersion$jscomp$inline_1676
       )
         throw Error(
           formatProdErrorMessage(
             527,
             isomorphicReactPackageVersion$jscomp$inline_1676,
-            "19.0.0-rc-5c56b873-20241107"
+            "19.0.0-rc-7c8e5e7a-20241101"
           )
         );
       ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -15972,25 +15990,25 @@
           null === componentOrElement ? null : componentOrElement.stateNode;
         return componentOrElement;
       };
-      var internals$jscomp$inline_2152 = {
+      var internals$jscomp$inline_2148 = {
         bundleType: 0,
-        version: "19.0.0-rc-5c56b873-20241107",
+        version: "19.0.0-rc-7c8e5e7a-20241101",
         rendererPackageName: "react-dom",
         currentDispatcherRef: ReactSharedInternals,
         findFiberByHostInstance: getClosestInstanceFromNode,
-        reconcilerVersion: "19.0.0-rc-5c56b873-20241107",
+        reconcilerVersion: "19.0.0-rc-7c8e5e7a-20241101",
       };
       if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
-        var hook$jscomp$inline_2153 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
+        var hook$jscomp$inline_2149 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
         if (
-          !hook$jscomp$inline_2153.isDisabled &&
-          hook$jscomp$inline_2153.supportsFiber
+          !hook$jscomp$inline_2149.isDisabled &&
+          hook$jscomp$inline_2149.supportsFiber
         )
           try {
-            (rendererID = hook$jscomp$inline_2153.inject(
-              internals$jscomp$inline_2152
+            (rendererID = hook$jscomp$inline_2149.inject(
+              internals$jscomp$inline_2148
             )),
-              (injectedHook = hook$jscomp$inline_2153);
+              (injectedHook = hook$jscomp$inline_2149);
           } catch (err) {}
       }
       exports.createRoot = function (container, options) {
@@ -16086,7 +16104,7 @@
         listenToAllSupportedEvents(container);
         return new ReactDOMHydrationRoot(initialChildren);
       };
-      exports.version = "19.0.0-rc-5c56b873-20241107";
+      exports.version = "19.0.0-rc-7c8e5e7a-20241101";
 
       /***/
     },
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js 
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js 
failed to diff
Commit: 47fcac0

eps1lon
eps1lon approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this automatically invalidated existing preferences?

@devjiwonchoi
Copy link
Member Author

devjiwonchoi commented Nov 12, 2024 •
edited
Loading

Does this automatically invalidated existing preferences?

Nope. Should we do so?

@devjiwonchoi devjiwonchoi merged commit b16f604 into canary Nov 12, 2024
107 checks passed
@devjiwonchoi devjiwonchoi deleted the jwn/8zfv branch November 12, 2024 19:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@samcx samcx Awaiting requested review from samcx

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devjiwonchoi @ijjk @eps1lon