Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: unify the header deps by removing # #72391

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

JamBalaya56562
Copy link
Contributor

Summary

Remove redundant # from error pages.

Description

Follow up #52038 and #72263.
Updated template.txt and clarified the header deps.
Then rewrite as per the template.

Improving Documentation

@ijjk ijjk added Documentation Related to Next.js' official documentation. Font (next/font) Related to Next.js Font Optimization. labels Nov 6, 2024
@ijjk
Copy link
Member

ijjk commented Nov 6, 2024

Allow CI Workflow Run

  • approve CI run for commit: c7d9eb9

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Nov 6, 2024

Allow CI Workflow Run

  • approve CI run for commit: c7d9eb9

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Nov 6, 2024

Allow CI Workflow Run

  • approve CI run for commit: 8c221bb

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@delbaoliveira delbaoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you @JamBalaya56562 🙏🏼

@delbaoliveira delbaoliveira merged commit 74a19b7 into vercel:canary Nov 7, 2024
39 checks passed
@JamBalaya56562 JamBalaya56562 deleted the sharp branch November 7, 2024 09:00
ijjk pushed a commit that referenced this pull request Nov 8, 2024
## Description
Follow up #72391.
I missed some error pages.

### Improving Documentation

- [x] Run `pnpm prettier-fix` to fix formatting issues before opening
the PR.
- [x] Read the Docs Contribution Guide to ensure your contribution
follows the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

Co-authored-by: Delba de Oliveira <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. Font (next/font) Related to Next.js Font Optimization. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants