Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace turbopack://[project]/... sourcemap uris with file://... in development #71489

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

wbinnssmith
Copy link
Member

@wbinnssmith wbinnssmith commented Oct 18, 2024

This makes working with devtools more straightforward, reduces our own overhead when tracing stack frames in the error overlay, etc.

Generated code from Turbopack or Next.js still use turbopack://[turbopack] or turbopack://[next] respectively.

Test Plan:

Closes PACK-3430

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Oct 18, 2024
@wbinnssmith wbinnssmith force-pushed the wbinnssmith/sourcemap-uri branch 2 times, most recently from 447ac28 to df05a43 Compare October 18, 2024 17:07
@ijjk
Copy link
Member

ijjk commented Oct 18, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 18, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js wbinnssmith/sourcemap-uri Change
buildDuration 18.2s 19.4s ⚠️ +1.2s
buildDurationCached 15.7s 13.7s N/A
nodeModulesSize 374 MB 373 MB N/A
nextStartRea..uration (ms) 417ms 418ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js wbinnssmith/sourcemap-uri Change
214a959c-HASH.js gzip 52.6 kB 52.6 kB N/A
3528-HASH.js gzip 45.1 kB 44.6 kB N/A
6581.HASH.js gzip 169 B 169 B
9113-HASH.js gzip 5.27 kB 5.27 kB N/A
framework-HASH.js gzip 57.4 kB 57.4 kB N/A
main-app-HASH.js gzip 230 B 232 B N/A
main-HASH.js gzip 33 kB 32.8 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB
Overall change 1.88 kB 1.88 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js wbinnssmith/sourcemap-uri Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js wbinnssmith/sourcemap-uri Change
_app-HASH.js gzip 192 B 193 B N/A
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 510 B 509 B N/A
css-HASH.js gzip 341 B 344 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 266 B 266 B
head-HASH.js gzip 362 B 364 B N/A
hooks-HASH.js gzip 390 B 391 B N/A
image-HASH.js gzip 4.41 kB 4.41 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.78 kB 2.78 kB N/A
routerDirect..HASH.js gzip 328 B 329 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 324 B 325 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.23 kB 1.23 kB
Client Build Manifests
vercel/next.js canary vercel/next.js wbinnssmith/sourcemap-uri Change
_buildManifest.js gzip 750 B 749 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js wbinnssmith/sourcemap-uri Change
index.html gzip 523 B 525 B N/A
link.html gzip 538 B 539 B N/A
withRouter.html gzip 518 B 520 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js wbinnssmith/sourcemap-uri Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 187 kB 187 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js wbinnssmith/sourcemap-uri Change
middleware-b..fest.js gzip 668 B 670 B N/A
middleware-r..fest.js gzip 156 B 155 B N/A
middleware.js gzip 31 kB 31 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js wbinnssmith/sourcemap-uri Change
973-experime...dev.js gzip 322 B 322 B
973.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 317 kB 317 kB N/A
app-page-exp..prod.js gzip 121 kB 121 kB N/A
app-page-tur..prod.js gzip 134 kB 134 kB N/A
app-page-tur..prod.js gzip 129 kB 129 kB N/A
app-page.run...dev.js gzip 308 kB 307 kB N/A
app-page.run..prod.js gzip 117 kB 117 kB N/A
app-route-ex...dev.js gzip 35.9 kB 35.9 kB N/A
app-route-ex..prod.js gzip 24.4 kB 24.4 kB N/A
app-route-tu..prod.js gzip 24.4 kB 24.4 kB N/A
app-route-tu..prod.js gzip 24.2 kB 24.2 kB N/A
app-route.ru...dev.js gzip 37.6 kB 37.5 kB N/A
app-route.ru..prod.js gzip 24.2 kB 24.2 kB N/A
pages-api-tu..prod.js gzip 9.61 kB 9.61 kB
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB
pages-api.ru..prod.js gzip 9.61 kB 9.61 kB
pages-turbo...prod.js gzip 20.9 kB 20.9 kB
pages.runtim...dev.js gzip 26.5 kB 26.5 kB
pages.runtim..prod.js gzip 20.9 kB 20.9 kB
server.runti..prod.js gzip 58.4 kB 58.4 kB N/A
Overall change 99.7 kB 99.7 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js wbinnssmith/sourcemap-uri Change
0.pack gzip 1.85 MB 1.86 MB ⚠️ +13.1 kB
index.pack gzip 143 kB 144 kB ⚠️ +694 B
Overall change 1.99 MB 2 MB ⚠️ +13.8 kB
Diff details
Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for image-HASH.js
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [8358],
   {
-    /***/ 7905: /***/ (
+    /***/ 3194: /***/ (
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -9,7 +9,7 @@
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/image",
         function () {
-          return __webpack_require__(2287);
+          return __webpack_require__(1499);
         },
       ]);
       if (false) {
@@ -18,7 +18,7 @@
       /***/
     },
 
-    /***/ 4266: /***/ (module, exports, __webpack_require__) => {
+    /***/ 3557: /***/ (module, exports, __webpack_require__) => {
       "use strict";
       /* __next_internal_client_entry_do_not_use__  cjs */
       Object.defineProperty(exports, "__esModule", {
@@ -40,17 +40,17 @@
         __webpack_require__(7921)
       );
       const _head = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(6686)
+        __webpack_require__(1685)
       );
-      const _getimgprops = __webpack_require__(6152);
-      const _imageconfig = __webpack_require__(7525);
-      const _imageconfigcontextsharedruntime = __webpack_require__(6909);
-      const _warnonce = __webpack_require__(694);
-      const _routercontextsharedruntime = __webpack_require__(1769);
+      const _getimgprops = __webpack_require__(2321);
+      const _imageconfig = __webpack_require__(8633);
+      const _imageconfigcontextsharedruntime = __webpack_require__(9251);
+      const _warnonce = __webpack_require__(2495);
+      const _routercontextsharedruntime = __webpack_require__(5906);
       const _imageloader = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(5427)
+        __webpack_require__(9630)
       );
-      const _usemergedref = __webpack_require__(7892);
+      const _usemergedref = __webpack_require__(7662);
       // This is replaced by webpack define plugin
       const configEnv = {
         deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
@@ -371,7 +371,7 @@
       /***/
     },
 
-    /***/ 7892: /***/ (module, exports, __webpack_require__) => {
+    /***/ 7662: /***/ (module, exports, __webpack_require__) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -432,7 +432,7 @@
       /***/
     },
 
-    /***/ 6152: /***/ (
+    /***/ 2321: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -448,9 +448,9 @@
           return getImgProps;
         },
       });
-      const _warnonce = __webpack_require__(694);
-      const _imageblursvg = __webpack_require__(411);
-      const _imageconfig = __webpack_require__(7525);
+      const _warnonce = __webpack_require__(2495);
+      const _imageblursvg = __webpack_require__(1103);
+      const _imageconfig = __webpack_require__(8633);
       const VALID_LOADING_VALUES =
         /* unused pure expression or super */ null && [
           "lazy",
@@ -824,7 +824,7 @@
       /***/
     },
 
-    /***/ 411: /***/ (__unused_webpack_module, exports) => {
+    /***/ 1103: /***/ (__unused_webpack_module, exports) => {
       "use strict";
       /**
        * A shared function, used on both client and server, to generate a SVG blur placeholder.
@@ -879,7 +879,7 @@
       /***/
     },
 
-    /***/ 2063: /***/ (
+    /***/ 4297: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -906,10 +906,10 @@
         },
       });
       const _interop_require_default = __webpack_require__(9608);
-      const _getimgprops = __webpack_require__(6152);
-      const _imagecomponent = __webpack_require__(4266);
+      const _getimgprops = __webpack_require__(2321);
+      const _imagecomponent = __webpack_require__(3557);
       const _imageloader = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(5427)
+        __webpack_require__(9630)
       );
       function getImageProps(imgProps) {
         const { props } = (0, _getimgprops.getImgProps)(imgProps, {
@@ -941,7 +941,7 @@
       /***/
     },
 
-    /***/ 5427: /***/ (__unused_webpack_module, exports) => {
+    /***/ 9630: /***/ (__unused_webpack_module, exports) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -976,7 +976,7 @@
       /***/
     },
 
-    /***/ 2287: /***/ (
+    /***/ 1499: /***/ (
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -993,8 +993,8 @@
 
       // EXTERNAL MODULE: ./node_modules/.pnpm/[email protected]/node_modules/react/jsx-runtime.js
       var jsx_runtime = __webpack_require__(2433);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-69d4b800-20241021_re_5ehui3izxi57mbto7db67nrlae/node_modules/next/image.js
-      var next_image = __webpack_require__(3447);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-69d4b800-20241021_re_lvlskvysvdaybwqbl4n7iaejzm/node_modules/next/image.js
+      var next_image = __webpack_require__(4593);
       var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // CONCATENATED MODULE: ./pages/nextjs.png
       /* harmony default export */ const nextjs = {
         src: "/_next/static/media/nextjs.cae0b805.png",
@@ -1024,12 +1024,12 @@
       /***/
     },
 
-    /***/ 3447: /***/ (
+    /***/ 4593: /***/ (
       module,
       __unused_webpack_exports,
       __webpack_require__
     ) => {
-      module.exports = __webpack_require__(2063);
+      module.exports = __webpack_require__(4297);
 
       /***/
     },
@@ -1039,7 +1039,7 @@
     /******/ var __webpack_exec__ = (moduleId) =>
       __webpack_require__((__webpack_require__.s = moduleId));
     /******/ __webpack_require__.O(0, [2888, 9774, 179], () =>
-      __webpack_exec__(7905)
+      __webpack_exec__(3194)
     );
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for 3528-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: c5b8757

@wbinnssmith wbinnssmith force-pushed the wbinnssmith/sourcemap-uri branch from df05a43 to b9c0f93 Compare October 18, 2024 20:40
@unstubbable
Copy link
Contributor

Hi Will, can you add https://github.com/vercel/next.js/blob/canary/test/development/app-dir/source-mapping/README.md to the test plan? There's no automatic tests for the React DevTools integration, so for now we need to check that manually whenever we're changing something about the source maps.

@wbinnssmith wbinnssmith force-pushed the wbinnssmith/sourcemap-uri branch from b9c0f93 to c2e25ab Compare October 21, 2024 18:21
@wbinnssmith wbinnssmith force-pushed the wbinnssmith/sourcemap-uri branch 4 times, most recently from 12a6612 to 002ac3a Compare October 21, 2024 22:01
@ijjk ijjk added the tests label Oct 21, 2024
@wbinnssmith wbinnssmith force-pushed the wbinnssmith/sourcemap-uri branch 2 times, most recently from 8861c5f to 4db3442 Compare October 21, 2024 22:54
@wbinnssmith wbinnssmith marked this pull request as ready for review October 21, 2024 23:01
@wbinnssmith
Copy link
Member Author

cc @sebmarkbage

@wbinnssmith
Copy link
Member Author

Hi Will, can you add https://github.com/vercel/next.js/blob/canary/test/development/app-dir/source-mapping/README.md to the test plan? There's no automatic tests for the React DevTools integration, so for now we need to check that manually whenever we're changing something about the source maps.

Confirmed that this passes as of 9e22f6f and the server component source file is shown in the stack frame.

@wbinnssmith wbinnssmith force-pushed the wbinnssmith/sourcemap-uri branch 6 times, most recently from b7b45e1 to 79db547 Compare October 21, 2024 23:50
@wbinnssmith wbinnssmith requested a review from mischnic October 22, 2024 00:25
@wbinnssmith wbinnssmith force-pushed the wbinnssmith/sourcemap-uri branch 2 times, most recently from 610bcc8 to 6b1082f Compare October 23, 2024 22:59
Copy link
Member Author

@wbinnssmith wbinnssmith force-pushed the wbinnssmith/sourcemap-uri branch 5 times, most recently from fed82a5 to 5119d61 Compare October 24, 2024 04:28
This makes working with devtools more straightforward, reduces our own overhead when tracing stack frames in the error overlay, etc.

Generated code from Turbopack or Next.js still use `turbopack://[turbopack]` or `turbopack://[next]` respectively.

Test Plan: CI. Update snapshots.
@wbinnssmith wbinnssmith force-pushed the wbinnssmith/sourcemap-uri branch from 5119d61 to c5b8757 Compare October 24, 2024 05:10
This is a very rudimentary, inelegant solution for adding
Turbopack-generated code to the sourcemap ignoreList.

- It hardcodes `turbopack://[turbopack]` and `turbopack://[next]` uri
prefixes into turbo pack core
- It depends on my fork of the `sourcemap` crate to implement
ignoreLists

Both of these should be fixed, but we want Dynamic IO to be usable soon.

---------

Co-authored-by: Benjamin Woodruff <[email protected]>
Co-authored-by: Tobias Koppers <[email protected]>
@wbinnssmith wbinnssmith merged commit 2a10d55 into canary Oct 24, 2024
31 of 36 checks passed
@wbinnssmith wbinnssmith deleted the wbinnssmith/sourcemap-uri branch October 24, 2024 06:11
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Oct 29, 2024
##### [v15.0.2](https://github.com/vercel/next.js/releases/tag/v15.0.2)

##### Core Changes

-   Read page name from work store in server module map proxy: [#71669](vercel/next.js#71669)
-   codemod: should not transform when param is not used: [#71664](vercel/next.js#71664)
-   \[dynamicIO] complete refactor to prerender: [#71687](vercel/next.js#71687)
-   fix: metadata image route normalize path posix for windows: [#71673](vercel/next.js#71673)
-   next-codemod(upgrade): optional catch when missing dev script: [#71598](vercel/next.js#71598)
-   Avoid server action function indirection in Turbopack: [#71628](vercel/next.js#71628)
-   fix: exclude `basePath` in `findSourceMapURL`: [#71719](vercel/next.js#71719)
-   fix: stack frame text color in dark mode: [#71656](vercel/next.js#71656)
-   Fix: revert the bad node binary handling: [#71723](vercel/next.js#71723)
-   next-codemod: add empty `pnpm-workspace.yaml` to test fixtures to bypass PNPM workspace checks: [#71726](vercel/next.js#71726)
-   warn on sync access if dynamicIO is not enabled: [#71696](vercel/next.js#71696)
-   Update React from `69d4b800-20241021` to `45804af1-20241021`: [#71718](vercel/next.js#71718)
-   next-upgrade: do not add `--turbopack` flag when `--turbo` exists in `next dev`: [#71730](vercel/next.js#71730)
-   feat: stitch errors with react owner stack: [#70393](vercel/next.js#70393)
-   \[dynamicIO] update data access error and documentation: [#71738](vercel/next.js#71738)
-   Test cached form action with revalidate: [#71591](vercel/next.js#71591)
-   Upgrade React from `45804af1-20241021` to `28668d39-20241023`: [#71745](vercel/next.js#71745)
-   Fix race condition when setting client reference manifests: [#71741](vercel/next.js#71741)
-   Fix fetch with no-store inside of use cache: [#71754](vercel/next.js#71754)
-   Remove the bottom collapse button in dev overlay: [#71658](vercel/next.js#71658)
-   \[dynamicIO] unify cache filling and lazy-module warming: [#71749](vercel/next.js#71749)
-   Don't filter out <anonymous> source location frames through RSC: [#71752](vercel/next.js#71752)
-   fix undefined default export error msg: [#71762](vercel/next.js#71762)
-   Upgrade React from `28668d39-20241023` to `1631855f-20241023`: [#71769](vercel/next.js#71769)
-   Enable owner stack in experimental build: [#71716](vercel/next.js#71716)
-   feat: add experiment for sharpjs cpu flags: [#71733](vercel/next.js#71733)
-   fix: handle server component replay error in error overlay: [#71772](vercel/next.js#71772)
-   Don't error asking for prebuilt bundles: [#71778](vercel/next.js#71778)
-   Replace `turbopack://[project]/...` sourcemap uris with `file://...` in development: [#71489](vercel/next.js#71489)
-   misc: update source map paths for bundled Next.js runtime: [#71779](vercel/next.js#71779)
-   \[dynamicIO] refine error message and docs: [#71781](vercel/next.js#71781)
-   next-upgrade: change `--turbo` to `--turbopack` if applicable: [#71737](vercel/next.js#71737)
-   Show all diff when uncollapse: [#71792](vercel/next.js#71792)
-   Sourcemap errors in terminal by default : [#71444](vercel/next.js#71444)
-   Fully enable custom error callbacks for app router: [#71794](vercel/next.js#71794)
-   Simplify Server Action Webpack plugin: [#71721](vercel/next.js#71721)
-   ensure DIO development segment errors are cleared after correcting: [#71811](vercel/next.js#71811)
-   Include sourceframe in errors logged in the terminal during development: [#71803](vercel/next.js#71803)
-   \[dynamicIO] update prerender cache scoping and cache warming for validation: [#71822](vercel/next.js#71822)
-   only force stack frame color in tty: [#71860](vercel/next.js#71860)
-   Add test for fetch with auth in use cache: [#71768](vercel/next.js#71768)
-   Fix race with hot-reloader-client clearing overlay errors: [#71771](vercel/next.js#71771)
-   Fix dynamic tracking in dev: [#71867](vercel/next.js#71867)
-   Revert "Sourcemap errors in terminal by default ([#71444](vercel/next.js#71444))": [#71868](vercel/next.js#71868)
-   Fix fetch caching inside of `"use cache"`: [#71793](vercel/next.js#71793)
-   Trace upload: only send traces for current session: [#71838](vercel/next.js#71838)
-   Reland "Sourcemap errors in terminal by default": [#71877](vercel/next.js#71877)
-   Implement information byte in Server Reference ID and other optimizations: [#71463](vercel/next.js#71463)
-   fix: webpack build error on Windows: [#71943](vercel/next.js#71943)
-   Run with `--enable-source-maps` by default in `next dev`: [#71820](vercel/next.js#71820)
-   fix global-error styles: [#71914](vercel/next.js#71914)
-   Use `registerClientReference` for ESM client component modules: [#71968](vercel/next.js#71968)
-   Fix missing `await` of `params` when metadata is used with an image file: [#71871](vercel/next.js#71871)
-   Upgrade React from `1631855f-20241023` to `02c0e824-20241028`: [#71979](vercel/next.js#71979)
-   Populate sourcemap `ignoreList` when Webpack is used: [#71821](vercel/next.js#71821)
-   \[dynamicIO] unify server and client prerender for non-ppr pathway: [#71764](vercel/next.js#71764)
-   codemod: add separator to the parenthenese expr: [#71993](vercel/next.js#71993)
-   Respect sourcemap's ignore list when printing errors in the terminal: [#71908](vercel/next.js#71908)
-   fix console color to be compatible in chrome devtools: [#71939](vercel/next.js#71939)
-   Delete obsolete codemod `next-dynamic-access-named-export`: [#72016](vercel/next.js#72016)
-   fix: log the error instance modified extra location info: [#71930](vercel/next.js#71930)
-   Compare error stack to dedupe error: [#71798](vercel/next.js#71798)

##### Example Changes

-   experimental.instrumentationHook is not necessary anymore: [#71808](vercel/next.js#71808)
-   Add Jude to nextjs team: [#71936](vercel/next.js#71936)

##### Misc Changes

-   docs: fix broken link in Architecture/Turbopack documentation: [#71412](vercel/next.js#71412)
-   test: migrate rest async api usage in tests: [#71663](vercel/next.js#71663)
-   fix: docs for dynamic routing in next 15: [#71531](vercel/next.js#71531)
-   Remove the 'new' keyword from the GET function sample code.: [#71671](vercel/next.js#71671)
-   chore: fix wrong path of comments: [#71682](vercel/next.js#71682)
-   docs(next-config): remove mention of appIsrStatus is on canary: [#71695](vercel/next.js#71695)
-   react-sync: Ignore update notices from npm: [#71717](vercel/next.js#71717)
-   Docs: Update default marker for fetch cache option: [#71728](vercel/next.js#71728)
-   \[docs] Fix page.tsx parameter types: [#71680](vercel/next.js#71680)
-   \[docs] Fix table.js containing TS code: [#71677](vercel/next.js#71677)
-   docs(ppr): update note about ppr: [#71697](vercel/next.js#71697)
-   docs lint: [#71748](vercel/next.js#71748)
-   fixes error message asserts and lints: [#71747](vercel/next.js#71747)
-   Fix docs for configuring Turbopack: [#71755](vercel/next.js#71755)
-   docs(turbo): add experimental icon to turbo config section: [#71761](vercel/next.js#71761)
-   feat(turbopack): Add `__turbopack_original__` while tree shaking: [#71547](vercel/next.js#71547)
-   test: re-enable test with note: [#71789](vercel/next.js#71789)
-   Docs: Remove beta marker from Turbopack docs: [#71796](vercel/next.js#71796)
-   Update docs 1: [#71812](vercel/next.js#71812)
-   docs lint fixes: [#71813](vercel/next.js#71813)
-   docs: remove `"use cache"` on before code snippet: [#71815](vercel/next.js#71815)
-   Next docs broken links: [#71823](vercel/next.js#71823)
-   \[Turbopack] add optimization based on upper count: [#71606](vercel/next.js#71606)
-   chore(turbo-tasks-backend): Use let instead of match for macro bindings: [#71756](vercel/next.js#71756)
-   chore(turbo-tasks-backend): Remove collapsible-if lints: [#71758](vercel/next.js#71758)
-   removing extra reference: [#71853](vercel/next.js#71853)
-   codemod(turbopack): Rewrite Vc fields in structs as ResolvedVc (part 3): [#71665](vercel/next.js#71665)
-   Update sync-dynamic-apis.mdx: [#71907](vercel/next.js#71907)
-   codemod(turbopack): Rewrite Vc fields in structs as ResolvedVc (part 4): [#71804](vercel/next.js#71804)
-   test: remove duplicated flaky test: [#71967](vercel/next.js#71967)
-   docs: Fix typo in cacheLife configs in use-cache docs: [#71921](vercel/next.js#71921)
-   Fix use cache example line highlights: [#71883](vercel/next.js#71883)
-   Allow breakpoints to be set in `packages/next/src/compiled`: [#71986](vercel/next.js#71986)
-   updated upgrade to v15 command in docs: [#71643](vercel/next.js#71643)
-   codemod(turbopack): Rewrite Vc fields in structs as ResolvedVc (part 5): [#71861](vercel/next.js#71861)
-   Clarify that streaming is blocked on generateMetadata for initial load: [#71985](vercel/next.js#71985)
-   Docs: Add legacy tags: [#71964](vercel/next.js#71964)
-   Docs: Fix broken link: [#72021](vercel/next.js#72021)
-   (docs) `use cache`: Add text code formatting: [#71999](vercel/next.js#71999)
-   docs: update file structure: [#71951](vercel/next.js#71951)
-   Documentation Fix: Correct `cacheTag` Function Usage: [#71912](vercel/next.js#71912)
-   correct expire calc & and Nested usage import in use-cache docs: [#71899](vercel/next.js#71899)
-   Docs: Address internal `use cache` comments : [#71981](vercel/next.js#71981)
-   Fix swc version mismatch when checking out an older version: [#71978](vercel/next.js#71978)

##### Credits

Huge thanks to [@ytori](https://github.com/ytori), [@unstubbable](https://github.com/unstubbable), [@huozhi](https://github.com/huozhi), [@SebassNoob](https://github.com/SebassNoob), [@tatsuteb](https://github.com/tatsuteb), [@Marukome0743](https://github.com/Marukome0743), [@gnoff](https://github.com/gnoff), [@samcx](https://github.com/samcx), [@devjiwonchoi](https://github.com/devjiwonchoi), [@imprakharshukla](https://github.com/imprakharshukla), [@migueldamota](https://github.com/migueldamota), [@eps1lon](https://github.com/eps1lon), [@ztanner](https://github.com/ztanner), [@timneutkens](https://github.com/timneutkens), [@cantemizyurek](https://github.com/cantemizyurek), [@sebmarkbage](https://github.com/sebmarkbage), [@padmaia](https://github.com/padmaia), [@ijjk](https://github.com/ijjk), [@styfle](https://github.com/styfle), [@wbinnssmith](https://github.com/wbinnssmith), [@feedthejim](https://github.com/feedthejim), [@kdy1](https://github.com/kdy1), [@shuding](https://github.com/shuding), [@molebox](https://github.com/molebox), [@ismaelrumzan](https://github.com/ismaelrumzan), [@sokra](https://github.com/sokra), [@bgw](https://github.com/bgw), [@timeyoutakeit](https://github.com/timeyoutakeit), [@AdonisAgelis](https://github.com/AdonisAgelis), [@chicoxyzzy](https://github.com/chicoxyzzy), [@gaojude](https://github.com/gaojude), [@elitalpa](https://github.com/elitalpa), [@t3dotgg](https://github.com/t3dotgg), [@gaearon](https://github.com/gaearon), [@nisabmohd](https://github.com/nisabmohd), [@gadcam](https://github.com/gadcam), [@delbaoliveira](https://github.com/delbaoliveira), [@bennettdams](https://github.com/bennettdams), [@wiscaksono](https://github.com/wiscaksono), and [@Developerayo](https://github.com/Developerayo) for helping!
stipsan pushed a commit to sanity-io/next.js that referenced this pull request Nov 6, 2024
…in development (vercel#71489)

This makes working with devtools more straightforward, reduces our own
overhead when tracing stack frames in the error overlay, etc.

Generated code from Turbopack or Next.js still use
`turbopack://[turbopack]` or `turbopack://[next]` respectively.

Test Plan: 
- [x] Update tests
- [x] CI
- [x]
https://github.com/vercel/next.js/blob/475bdb1f743bf0b3552b40f85b615d87f4ae4904/test/development/app-dir/source-mapping/README.md

---------

Co-authored-by: Benjamin Woodruff <[email protected]>
Co-authored-by: Tobias Koppers <[email protected]>
stipsan pushed a commit to sanity-io/next.js that referenced this pull request Nov 6, 2024
@github-actions github-actions bot added the locked label Nov 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked tests Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants