Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: module resolution for next.config.ts is currently limited to CommonJS #71162

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Oct 11, 2024

Why?

In current state, next.config.ts cannot resolve Native ESM syntax. Therefore it may import extensions .js, .mjs, .cjs, it will throw when the imported module uses Native ESM syntax like top-level await.

Closes NDX-368

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. labels Oct 11, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @devjiwonchoi and the rest of your teammates on Graphite Graphite

@devjiwonchoi devjiwonchoi marked this pull request as ready for review October 11, 2024 20:23
@devjiwonchoi devjiwonchoi requested a review from ijjk October 13, 2024 17:09
@devjiwonchoi devjiwonchoi merged commit d6b932d into canary Oct 14, 2024
51 checks passed
@devjiwonchoi devjiwonchoi deleted the 10-12-docs_module_resolution_for_next.config.ts_is_currently_limited_to_commonjs_ branch October 14, 2024 09:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants