Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip generating cert each time #67122

Merged
merged 3 commits into from
Sep 13, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions packages/next/src/lib/mkcert.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import fs from 'fs'
import path from 'path'
import fs from 'node:fs'
import path from 'node:path'
import { X509Certificate, createPublicKey } from 'node:crypto'
import { getCacheDirectory } from './helpers/get-cache-directory'
import * as Log from '../build/output/log'
import { execSync } from 'child_process'
import { execSync } from 'node:child_process'
const { WritableStream } = require('node:stream/web') as {
WritableStream: typeof global.WritableStream
}
Expand Down Expand Up @@ -112,6 +113,22 @@ export async function createSelfSignedCertificate(
const keyPath = path.resolve(resolvedCertDir, 'localhost-key.pem')
const certPath = path.resolve(resolvedCertDir, 'localhost.pem')

if (host && fs.existsSync(keyPath) && fs.existsSync(certPath)) {
const cert = new X509Certificate(fs.readFileSync(certPath))
const key = fs.readFileSync(keyPath)

if (cert.checkHost(host) && cert.checkPrivateKey(createPublicKey(key))) {
Log.info('Using already generated self signed certificate')
const caLocation = execSync(`"${binaryPath}" -CAROOT`).toString().trim()

return {
key: keyPath,
cert: certPath,
rootCA: `${caLocation}/rootCA.pem`,
}
}
}

Log.info(
'Attempting to generate self signed certificate. This may prompt for your password'
)
Expand Down
Loading