Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant React dependency declarations in test #66530

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Remove redundant React dependency declarations in test #66530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
827fabf
Remove redundant React dependency declarations in test
eps1lon Jun 4, 2024
98eb4ed
Adjust tests that wrongfully use React as specified in examples
eps1lon Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion run-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,8 @@ ${ENDGROUP}`)
// a starter Next.js install to re-use to speed up tests
// to avoid having to run yarn each time
console.log(`${GROUP}Creating Next.js install for isolated tests`)
const reactVersion = process.env.NEXT_TEST_REACT_VERSION || 'beta'
const reactVersion =
process.env.NEXT_TEST_REACT_VERSION || '19.0.0-rc-f994737d14-20240522'
const { installDir, pkgPaths, tmpRepoDir } = await createNextInstall({
parentSpan: mockTrace(),
dependencies: {
Expand Down
4 changes: 0 additions & 4 deletions test/development/acceptance-app/ReactRefresh.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ import { outdent } from 'outdent'
describe('ReactRefresh app', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})

Expand Down
4 changes: 0 additions & 4 deletions test/development/acceptance-app/ReactRefreshLogBox-builtins.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ import { outdent } from 'outdent'
describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})

Expand Down
2 changes: 0 additions & 2 deletions test/development/acceptance-app/ReactRefreshLogBox-scss.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ describe.skip('ReactRefreshLogBox scss app', () => {
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
sass: 'latest',
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})
Expand Down
4 changes: 0 additions & 4 deletions test/development/acceptance-app/ReactRefreshLogBox.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ const IS_TURBOPACK = Boolean(process.env.TURBOPACK)
describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})

Expand Down
4 changes: 0 additions & 4 deletions test/development/acceptance-app/ReactRefreshLogBoxMisc.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ import { outdent } from 'outdent'
describe.skip('ReactRefreshLogBox app', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})

Expand Down
4 changes: 0 additions & 4 deletions test/development/acceptance-app/ReactRefreshModule.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ import { outdent } from 'outdent'
describe('ReactRefreshModule app', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})

Expand Down
2 changes: 0 additions & 2 deletions test/development/acceptance-app/ReactRefreshRegression.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ describe('ReactRefreshRegression app', () => {
'styled-components': '5.1.0',
'@next/mdx': 'canary',
'@mdx-js/loader': '0.18.0',
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})
Expand Down
4 changes: 0 additions & 4 deletions test/development/acceptance-app/ReactRefreshRequire.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ import { outdent } from 'outdent'
describe('ReactRefreshRequire app', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})

Expand Down
4 changes: 0 additions & 4 deletions test/development/acceptance-app/editor-links.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ async function clickImportTraceFiles(browser: any) {
describe('Error overlay - editor links', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})

Expand Down
4 changes: 0 additions & 4 deletions test/development/acceptance-app/error-message-url.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ import { outdent } from 'outdent'
describe('Error overlay - error message urls', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})

Expand Down
4 changes: 0 additions & 4 deletions test/development/acceptance-app/error-recovery.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ import { outdent } from 'outdent'
describe.each(['default', 'turbo'])('Error recovery app %s', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})

Expand Down
4 changes: 0 additions & 4 deletions test/development/acceptance-app/hydration-error.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ import { getRedboxTotalErrorCount } from 'next-test-utils'
describe('Error overlay for hydration errors', () => {
const { next, isTurbopack } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})

Expand Down
2 changes: 0 additions & 2 deletions test/development/acceptance-app/invalid-imports.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ describe('Error Overlay invalid imports', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
'server-only': 'latest',
'client-only': 'latest',
},
Expand Down
4 changes: 0 additions & 4 deletions test/development/acceptance-app/rsc-build-errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ import { outdent } from 'outdent'
describe('Error overlay - RSC build errors', () => {
const { next, isTurbopack } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'rsc-build-errors')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})

Expand Down
4 changes: 0 additions & 4 deletions test/development/acceptance-app/server-components.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ import { outdent } from 'outdent'
describe('Error Overlay for server components', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})

Expand Down
4 changes: 0 additions & 4 deletions test/development/acceptance/hydration-error.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ import path from 'path'
describe('Error overlay for hydration errors', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})

Expand Down
4 changes: 0 additions & 4 deletions test/development/acceptance/server-component-compiler-errors-in-pages.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@ const initialFiles = new Map([
describe('Error Overlay for server components compiler errors in pages', () => {
const { next } = nextTestSetup({
files: {},
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
skipStart: true,
})

Expand Down
2 changes: 0 additions & 2 deletions test/development/next-font/deprecated-package.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ describe('Deprecated @next/font warning', () => {
'pages/index.js': '',
},
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
'@next/font': 'canary',
},
skipStart: true,
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/app-dir/actions-allowed-origins/app-action-allowed-origins.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ describe('app-dir action allowed origins', () => {
files: join(__dirname, 'safe-origins'),
skipDeployment: true,
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
'server-only': 'latest',
},
// An arbitrary & random port.
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/app-dir/actions-allowed-origins/app-action-disallowed-origins.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ describe('app-dir action disallowed origins', () => {
files: join(__dirname, 'unsafe-origins'),
skipDeployment: true,
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
'server-only': 'latest',
},
})
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/app-dir/actions/app-action-export.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ describe('app-dir action handling - next export', () => {
skipStart: true,
skipDeployment: true,
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
'server-only': 'latest',
},
})
Expand Down
4 changes: 0 additions & 4 deletions test/e2e/app-dir/actions/app-action-form-state.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ import { check } from 'next-test-utils'
describe('app-dir action useActionState', () => {
const { next } = nextTestSetup({
files: __dirname,
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
})
it('should support submitting form state with JS', async () => {
const browser = await next.browser('/client/form-state')
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/app-dir/actions/app-action-progressive-enhancement.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ describe('app-dir action progressive enhancement', () => {
const { next } = nextTestSetup({
files: __dirname,
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
nanoid: 'latest',
'react-dom': '19.0.0-rc-f994737d14-20240522',
'server-only': 'latest',
},
})
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/app-dir/actions/app-action-size-limit-invalid.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ describe('app-dir action size limit invalid config', () => {
skipDeployment: true,
skipStart: true,
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
'server-only': 'latest',
},
})
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/app-dir/actions/app-action.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ describe('app-dir action handling', () => {
nextTestSetup({
files: __dirname,
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
nanoid: 'latest',
'react-dom': '19.0.0-rc-f994737d14-20240522',
'server-only': 'latest',
},
})
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/app-dir/app-css-pageextensions/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ describe('app dir - css with pageextensions', () => {
skipDeployment: true,
dependencies: {
'@picocss/pico': '1.5.7',
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
sass: 'latest',
},
})
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/app-dir/app-css/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ describe('app dir - css', () => {
skipDeployment: true,
dependencies: {
'@picocss/pico': '1.5.7',
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
sass: 'latest',
'@next/mdx': 'canary',
},
Expand Down
4 changes: 0 additions & 4 deletions test/e2e/app-dir/app-routes-client-component/app-routes-client-component.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ import path from 'path'
describe('referencing a client component in an app route', () => {
const { next } = nextTestSetup({
files: new FileRef(path.join(__dirname)),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
})

it('responds without error', async () => {
Expand Down
12 changes: 0 additions & 12 deletions test/e2e/app-dir/create-root-layout/create-root-layout.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,6 @@ import stripAnsi from 'strip-ansi'
path.join(__dirname, 'next.config.js')
),
},
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
})
})
afterAll(() => next.destroy())
Expand Down Expand Up @@ -127,10 +123,6 @@ import stripAnsi from 'strip-ansi'
path.join(__dirname, 'next.config.js')
),
},
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
})
})
afterAll(() => next.destroy())
Expand Down Expand Up @@ -236,10 +228,6 @@ import stripAnsi from 'strip-ansi'
path.join(__dirname, 'next.config.js')
),
},
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
})

await expect(next.start()).rejects.toThrow('next build failed')
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/app-dir/interoperability-with-pages/navigation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ describe('navigation between pages and app dir', () => {
next = await createNext({
files: new FileRef(__dirname),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
typescript: 'latest',
'@types/react': 'latest',
'@types/node': 'latest',
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/app-dir/rewrites-redirects/rewrites-redirects.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ describe('redirects and rewrites', () => {
const { next } = nextTestSetup({
files: __dirname,
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
typescript: 'latest',
'@types/react': 'latest',
'@types/node': 'latest',
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/new-link-behavior/child-a-tag-error.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ describe('New Link Behavior with <a> child', () => {
},
dependencies: {
next: 'latest',
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
})
})
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/new-link-behavior/material-ui.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ describe('New Link Behavior with material-ui', () => {
'@mui/material': 'latest',
next: 'latest',
'prop-types': 'latest',
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
// Use minimum peer dep version instead of v9 of eslint to avoid breaking changes
eslint: '8.56.0',
'eslint-config-next': 'latest',
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/new-link-behavior/stitches.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ describe('New Link Behavior with stitches', () => {
dependencies: {
'@stitches/react': '^1.2.6',
next: 'latest',
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
})
})
Expand Down
4 changes: 0 additions & 4 deletions test/e2e/next-font/with-proxy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ describe('next/font/google with proxy', () => {

next = await createNext({
files: new FileRef(join(__dirname, 'with-proxy')),
dependencies: {
react: '19.0.0-rc-f994737d14-20240522',
'react-dom': '19.0.0-rc-f994737d14-20240522',
},
env: {
http_proxy: 'http://localhost:' + PROXY_PORT,
},
Expand Down
Loading
Loading