Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete isNodeDebugging option from next server #66229

Closed
wants to merge 1 commit into from
Closed

Remove obsolete isNodeDebugging option from next server #66229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/next/src/server/base-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,6 @@ export interface Options {
* The HTTP Server that Next.js is running behind
*/
httpServer?: HTTPServer

isNodeDebugging?: 'brk' | boolean
}

export type RenderOpts = PagesRenderOptsPartial & AppRenderOptsPartial
Expand Down
2 changes: 0 additions & 2 deletions packages/next/src/server/lib/render-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ async function initializeImpl(opts: {
dev: boolean
minimalMode?: boolean
hostname?: string
isNodeDebugging: boolean
keepAliveTimeout?: number
serverFields?: any
server?: any
Expand All @@ -103,7 +102,6 @@ async function initializeImpl(opts: {
customServer: false,
httpServer: opts.server,
port: opts.port,
isNodeDebugging: opts.isNodeDebugging,
})
requestHandler = app.getRequestHandler()
upgradeHandler = app.getUpgradeHandler()
Expand Down
2 changes: 0 additions & 2 deletions packages/next/src/server/lib/router-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ export async function initialize(opts: {
server?: import('http').Server
minimalMode?: boolean
hostname?: string
isNodeDebugging: boolean
keepAliveTimeout?: number
customServer?: boolean
experimentalHttpsServer?: boolean
Expand Down Expand Up @@ -599,7 +598,6 @@ export async function initialize(opts: {
minimalMode: opts.minimalMode,
dev: !!opts.dev,
server: opts.server,
isNodeDebugging: !!opts.isNodeDebugging,
serverFields: developmentBundler?.serverFields || {},
experimentalTestProxy: !!config.experimental.testProxy,
experimentalHttpsServer: !!opts.experimentalHttpsServer,
Expand Down
4 changes: 0 additions & 4 deletions packages/next/src/server/lib/start-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ export async function getRequestHandlers({
server,
hostname,
minimalMode,
isNodeDebugging,
keepAliveTimeout,
experimentalHttpsServer,
quiet,
Expand All @@ -64,7 +63,6 @@ export async function getRequestHandlers({
server?: import('http').Server
hostname?: string
minimalMode?: boolean
isNodeDebugging?: boolean
keepAliveTimeout?: number
experimentalHttpsServer?: boolean
quiet?: boolean
Expand All @@ -76,7 +74,6 @@ export async function getRequestHandlers({
dev: isDev,
minimalMode,
server,
isNodeDebugging: isNodeDebugging || false,
keepAliveTimeout,
experimentalHttpsServer,
startServerSpan,
Expand Down Expand Up @@ -304,7 +301,6 @@ export async function startServer(
server,
hostname,
minimalMode,
isNodeDebugging: Boolean(nodeDebugType),
keepAliveTimeout,
experimentalHttpsServer: !!selfSignedCertificate,
})
Expand Down
4 changes: 0 additions & 4 deletions packages/next/src/server/next.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import { PHASE_PRODUCTION_SERVER } from '../shared/lib/constants'
import { getTracer } from './lib/trace/tracer'
import { NextServerSpan } from './lib/trace/constants'
import { formatUrl } from '../shared/lib/router/utils/format-url'
import { getNodeDebugType } from './lib/utils'

let ServerImpl: typeof Server

Expand Down Expand Up @@ -275,15 +274,12 @@ class NextCustomServer extends NextServer {
const { getRequestHandlers } =
require('./lib/start-server') as typeof import('./lib/start-server')

const isNodeDebugging = typeof getNodeDebugType() === 'string'

const initResult = await getRequestHandlers({
dir: this.options.dir!,
port: this.options.port || 3000,
isDev: !!this.options.dev,
hostname: this.options.hostname || 'localhost',
minimalMode: this.options.minimalMode,
isNodeDebugging,
quiet: this.options.quiet,
})
this.requestHandler = initResult[0]
Expand Down
Loading