Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflow): update artifact actions #61061

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Jan 24, 2024

What

Closes PACK-2284

This PR upgrades upload/download-artifact action to the latest version. Per its claim, it can be faster 90% compare to the current in worst case use case.

Below's comparision between this PR vs. current branch for the datadog report

image
image

Cuts download time meaningfully different. Since we use upload/download in other places as well (i.e download next-swc binary) overall CI time would be improved.

The challenage is artifact@v4 introduced breaking changes to not to allow implicitly merge upload / download with duplicated name. PR introduced unique key for those, then apply download with pattern & merge.

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 24, 2024
@kwonoj kwonoj changed the title ci(workflow): update artifact actions [DONOTMERGE] ci(workflow): update artifact actions Jan 24, 2024
@ijjk
Copy link
Member

ijjk commented Jan 24, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js artifact-action-redux Change
buildDuration 14.5s 14.5s N/A
buildDurationCached 7.4s 6.7s N/A
nodeModulesSize 200 MB 200 MB
nextStartRea..uration (ms) 471ms 482ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js artifact-action-redux Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
411-HASH.js gzip 29.8 kB 29.8 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 243 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.6 kB 98.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js artifact-action-redux Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js artifact-action-redux Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.4 kB 3.4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js artifact-action-redux Change
_buildManifest.js gzip 484 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js artifact-action-redux Change
index.html gzip 527 B 526 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 522 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js artifact-action-redux Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 149 kB 149 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js artifact-action-redux Change
middleware-b..fest.js gzip 623 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.6 kB 37.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary vercel/next.js artifact-action-redux Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 95.6 kB 95.6 kB
app-page-tur..prod.js gzip 96.3 kB 96.3 kB
app-page-tur..prod.js gzip 90.9 kB 90.9 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.2 kB 90.2 kB
app-route-ex...dev.js gzip 22.2 kB 22.2 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.5 kB 14.5 kB
app-route.ru...dev.js gzip 21.6 kB 21.6 kB
app-route.ru..prod.js gzip 14.5 kB 14.5 kB
pages-api-tu..prod.js gzip 9.41 kB 9.41 kB
pages-api.ru...dev.js gzip 9.68 kB 9.68 kB
pages-api.ru..prod.js gzip 9.4 kB 9.4 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 932 kB 932 kB
Commit: a356e8b

@kwonoj kwonoj force-pushed the artifact-action-redux branch from 3ec840d to 0076a39 Compare January 24, 2024 01:58
@ijjk
Copy link
Member

ijjk commented Jan 24, 2024

Tests Passed

@kwonoj kwonoj force-pushed the artifact-action-redux branch 2 times, most recently from 31f262f to 1a40137 Compare January 24, 2024 03:22
@kwonoj kwonoj force-pushed the artifact-action-redux branch from 1a40137 to a356e8b Compare January 24, 2024 17:46
@kwonoj kwonoj changed the title [DONOTMERGE] ci(workflow): update artifact actions ci(workflow): update artifact actions Jan 24, 2024
@kwonoj kwonoj marked this pull request as ready for review January 24, 2024 18:40
@kwonoj kwonoj requested review from a team as code owners January 24, 2024 18:40
@kwonoj kwonoj requested review from leerob and lydiahallie and removed request for a team January 24, 2024 18:40
@timneutkens timneutkens merged commit a9c7559 into canary Jan 25, 2024
83 of 85 checks passed
@timneutkens timneutkens deleted the artifact-action-redux branch January 25, 2024 08:39
@github-actions github-actions bot added the locked label Feb 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants