Fix #5674 Append crossOrigin on the client side too, add config option for crossOrigin #5873
+53
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
reviewed
Dec 12, 2018
timneutkens
reviewed
Dec 12, 2018
timneutkens
reviewed
Dec 12, 2018
|
Will ship to canary in the morning 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5674
This adds config option
This config option is defined in the webpack Define Plugin at build.
HeadandNextScriptnow use the config option, if it's not explicitly set on the element.This value is now passed to Webpack so it can add it to scripts that it loads.
The value is now used in
PageLoader(on the client) so it can add it to the scripts and links that it loads.Using
<Head crossOrigin>or<NextScript crossOrigin>is now deprecated.