Prefer module over main on main fields for app router server compiler

[huozhi]

Reverts #56766
Reland #56532

x-ref: https://vercel.slack.com/archives/C04DUD7EB1B/p1697576563771229?thread_ts=1697146531.305779&cid=C04DUD7EB1B

This change was breaking package which was actually a dual package but marked as esm module, and when the package is ESM but import a CJS dependency without fully spepcified file path it will fail to resolve. The way is to either remove the esmodule type in package.json or change the import to full path import with extension for the package

[ijjk]

Stats from current PR

Default Build

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js revert-56766-revert/56532	Change
buildDuration	10.3s	10.4s	⚠️ +129ms
buildDurationCached	6.1s	6.2s	N/A
nodeModulesSize	175 MB	175 MB	⚠️ +7.17 kB
nextStartRea..uration (ms)	532ms	532ms	✓

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js revert-56766-revert/56532	Change
199-HASH.js gzip	27.5 kB	27.5 kB	N/A
3f784ff6-HASH.js gzip	53.3 kB	53.3 kB	✓
99.HASH.js gzip	182 B	182 B	✓
framework-HASH.js gzip	45.3 kB	45.3 kB	✓
main-app-HASH.js gzip	254 B	252 B	N/A
main-HASH.js gzip	32.9 kB	32.9 kB	N/A
webpack-HASH.js gzip	1.75 kB	1.75 kB	N/A
Overall change	98.8 kB	98.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js revert-56766-revert/56532	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js revert-56766-revert/56532	Change
_app-HASH.js gzip	206 B	205 B	N/A
_error-HASH.js gzip	182 B	180 B	N/A
amp-HASH.js gzip	506 B	505 B	N/A
css-HASH.js gzip	322 B	323 B	N/A
dynamic-HASH.js gzip	2.57 kB	2.57 kB	N/A
edge-ssr-HASH.js gzip	260 B	259 B	N/A
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	369 B	369 B	✓
image-HASH.js gzip	4.36 kB	4.36 kB	N/A
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.64 kB	2.63 kB	N/A
routerDirect..HASH.js gzip	312 B	311 B	N/A
script-HASH.js gzip	385 B	384 B	N/A
withRouter-HASH.js gzip	307 B	308 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	1.08 kB	1.08 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js revert-56766-revert/56532	Change
_buildManifest.js gzip	484 B	482 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js revert-56766-revert/56532	Change
index.html gzip	530 B	529 B	N/A
link.html gzip	542 B	542 B	✓
withRouter.html gzip	524 B	524 B	✓
Overall change	1.07 kB	1.07 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js revert-56766-revert/56532	Change
edge-ssr.js gzip	93.7 kB	93.7 kB	N/A
page.js gzip	155 kB	155 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js revert-56766-revert/56532	Change
middleware-b..fest.js gzip	623 B	621 B	N/A
middleware-r..fest.js gzip	150 B	151 B	N/A
middleware.js gzip	22.5 kB	22.5 kB	N/A
edge-runtime..pack.js gzip	1.92 kB	1.92 kB	✓
Overall change	1.92 kB	1.92 kB	✓

Commit: 05e88bf

[ijjk]

Failing test suites

Commit: 06c9e30

pnpm test test/integration/create-next-app/templates-app.test.ts

• create-next-app --app > should create TS appDir projects with --ts
• create-next-app --app > should create JS appDir projects with --js
• create-next-app --app > should create JS appDir projects with --js --src-dir
• create-next-app --app > should create Tailwind CSS appDir projects with --tailwind

Expand output

● create-next-app --app › should create TS appDir projects with --ts

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:83:54)
  at shouldBeTemplateProject (integration/create-next-app/lib/utils.ts:133:3)
  at integration/create-next-app/templates-app.test.ts:84:30
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/templates-app.test.ts:64:5)

● create-next-app --app › should create JS appDir projects with --js

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:83:54)
  at shouldBeTemplateProject (integration/create-next-app/lib/utils.ts:133:3)
  at integration/create-next-app/templates-app.test.ts:114:30
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/templates-app.test.ts:94:5)

● create-next-app --app › should create JS appDir projects with --js --src-dir

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:83:54)
  at shouldBeTemplateProject (integration/create-next-app/lib/utils.ts:133:3)
  at integration/create-next-app/templates-app.test.ts:146:30
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/templates-app.test.ts:125:5)

● create-next-app --app › should create Tailwind CSS appDir projects with --tailwind

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:83:54)
  at shouldBeTemplateProject (integration/create-next-app/lib/utils.ts:133:3)
  at integration/create-next-app/templates-app.test.ts:182:30
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/templates-app.test.ts:162:5)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Tests Passed