Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(turbopack): write manifests for edge app pages and use proper edge entry #56675

Merged
merged 20 commits into from
Oct 24, 2023

Conversation

ForsakenHarmony
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony commented Oct 10, 2023

Description

  • We previously didn't write to the shared middleware-manifest.json for edge app pages
  • We also need to manually write to the _ENTRIES object in turbopack entries because it currently doesn't have a way to change the output type like webpack: https://webpack.js.org/configuration/output/#type-assign-properties
  • Also need to write a bunch of manifests as JS files to be able to load them from the edge runtime.
  • Some import map fixes were needed as well.

This only fixes dev, build will need more work.

Closes WEB-1698

@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the Turbopack team. type: next labels Oct 10, 2023
@ForsakenHarmony
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ijjk
Copy link
Member

ijjk commented Oct 10, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 10, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js hrmny/web-1698-edge-app-pages-support Change
buildDuration 10.5s 10.4s N/A
buildDurationCached 6s 6s
nodeModulesSize 174 MB 174 MB ⚠️ +10.1 kB
nextStartRea..uration (ms) 424ms 418ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js hrmny/web-1698-edge-app-pages-support Change
199-HASH.js gzip 27.9 kB 27.9 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 33 kB 33 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js hrmny/web-1698-edge-app-pages-support Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js hrmny/web-1698-edge-app-pages-support Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary vercel/next.js hrmny/web-1698-edge-app-pages-support Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js hrmny/web-1698-edge-app-pages-support Change
index.html gzip 528 B 529 B N/A
link.html gzip 541 B 541 B
withRouter.html gzip 524 B 524 B
Overall change 1.06 kB 1.06 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js hrmny/web-1698-edge-app-pages-support Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 158 kB 158 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js hrmny/web-1698-edge-app-pages-support Change
middleware-b..fest.js gzip 624 B 624 B
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.55 kB 2.55 kB
Diff details
Diff for page.js

Diff too large to display

Commit: 72eef0f

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-1698-edge-app-pages-support branch 2 times, most recently from 8c8e574 to 0d07698 Compare October 11, 2023 13:30
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-1698-edge-app-pages-support branch from 0d07698 to ba9d0b0 Compare October 16, 2023 15:33
@ForsakenHarmony ForsakenHarmony changed the base branch from canary to hrmny/template-edge-ssr-loader October 16, 2023 16:08
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/template-edge-ssr-loader branch from 66c1649 to 3d6c7f1 Compare October 16, 2023 16:38
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-1698-edge-app-pages-support branch from ba9d0b0 to c51a21e Compare October 16, 2023 16:39
Base automatically changed from hrmny/template-edge-ssr-loader to canary October 20, 2023 20:19
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-1698-edge-app-pages-support branch from c51a21e to 9219c00 Compare October 22, 2023 21:58
@ForsakenHarmony ForsakenHarmony changed the title fix(turbopack): write middleware manifest for edge app pages and use proper edge entry fix(turbopack): write manifests for edge app pages and use proper edge entry Oct 22, 2023
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-1698-edge-app-pages-support branch 3 times, most recently from 11ad452 to 8f01ba0 Compare October 23, 2023 22:26
@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review October 23, 2023 22:46
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-1698-edge-app-pages-support branch from cca1904 to c57d4d2 Compare October 23, 2023 23:10
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sokra
sokra previously approved these changes Oct 24, 2023
@kodiakhq kodiakhq bot merged commit 679a398 into canary Oct 24, 2023
@kodiakhq kodiakhq bot deleted the hrmny/web-1698-edge-app-pages-support branch October 24, 2023 00:47
@github-actions github-actions bot added the locked label Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants