Clarify Choice Using Pipe Symbol (|) #56603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace '/' with '|' to indicate the file options clearly. it is confusing and could be misunderstood
sojinsamuel
requested review from
manovotny and
Nutlope
and removed request for
a team
|
@sojinsamuel thanks for pointing this out to us. We're going to close this PR and take care of all instances in #56712 instead. |
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 12, 2023
Based on feedback from #56603, the `/` can be interpreted as file paths instead of filename separators / delimiters. We'll change them to use pipes `|` instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
/with|to indicate the file options clearly. it is confusing and could be misunderstood.Its obvious that files can't be nested. but while reading, i stopped for a couple of seconds and assumed it was a mistake in the docs, then while comparing with file paths, rather than the obvious. what i found is the space around the
/when treated as an OR and no surrounding spaces when treated as a file path. I want beginners like me to understand the intend at a glance.Let's make it clear. this is an OR