fix: removed lucide aliases #53789
fix: removed lucide aliases #53789
Conversation
lucide-icons/lucide#1486 Lucide is now having a file for every alias that just contains `export {default} from "./icon-name"`.
| '(Stars|LucideStars|StarsIcon)': | ||
| 'modularize-import-loader?name={{ member }}&from=default&as=default&join=../esm/icons/sparkles!lucide-react', |
There was a problem hiding this comment.
Now there is a /esm/icons/stars.js file containining a simple reexport from ./sparkles.js.
/**
* lucide-react v0.267.0 - ISC
*/
export { default } from './sparkles.js';
//# sourceMappingURL=stars.js.map
jguddas
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim and
ztanner
as code owners
|
Notifying the following users due to files changed in this PR based on this repo's notify modifiers: @timneutkens, @ijjk, @shuding, @styfle, @huozhi: |
1 similar comment
|
Notifying the following users due to files changed in this PR based on this repo's notify modifiers: @timneutkens, @ijjk, @shuding, @styfle, @huozhi: |
|
lucide-react imports seem broken until this is merged, or that's what I understood from Lucide's discord |
The problem is that every time something changes in lucide-react, the library maintainers will have to come here and fix the rules again if they break. I think it's ok for older versions to not be optimized, as long as they are not broken. |
@shuding old versions of lucide are already broken, since they use There are only very view versions that have both Keeping those aliases here will break as soon as we add a If there are 250 or 253 prerelease versions of lucide that don't work is IMO okay considering this problem. |
…ig (#54572) ## Implementation Base on #54530, we're implementing a `optimize_barrel` transform to optimize barrel files to only export the names we need. If the transformed file isn't a "barrel file", we just re-export the names from it without any transformation. Take `lucide-react` as an example, with #54530 we are able to transform ```js import { IceCream } from 'lucide-react' ``` to ```js import { IceCream } from '__barrel_optimize__?names=IceCream!=!lucide-react?__barrel_optimize_noop__=IceCream' ``` And then, we apply that new request with a new Webpack module rule to use the SWC loader with option `optimizeBarrelExports: ['IceCream']`, which eventually got passed to this new `optimize_barrel` transform and does the optimization. ## Notes We'll have to add a new `getModularizeImportAliases` alias list to map `lucide-react` to the ESM version, as we have the `['main', 'module']` resolve order for the server compiler. Otherwise this optimization doesn't work in that compiler. There's no e2e test added because it's already covered by the `modularize-imports` test as we removed the default `lucide-react` transform rules and it still works. We'll need to test other libs before migrating them to the new `optimizePackageImports` option. --- Closes #54571, closes #53605, closes #53789, closes #53894, closes #54063.
#53483 introduced support for lucide aliases in next.js, to not have to maintain this mapping in two places lucide will have a file for every alias.
lucide-icons/lucide#1486