Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed wrong snippet (duplicated) #52903

Closed
wants to merge 1 commit into from
Closed

Removed wrong snippet (duplicated) #52903

wants to merge 1 commit into from

Conversation

SalvatoreCampagnese
Copy link

No description provided.

@SalvatoreCampagnese SalvatoreCampagnese requested review from a team as code owners July 19, 2023 19:43
styfle
styfle reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplicate code is expected because it should toggle using the switcher here:

image

So there must be a typo preventing the switcher from working as expected

@styfle styfle mentioned this pull request Jul 19, 2023
Closed
@SalvatoreCampagnese
Copy link
Author

SalvatoreCampagnese commented Jul 19, 2023 •
edited
Loading

Oh @styfle you are right!
I didn't expect it to work that way, I tought it was a duplicated code.

@styfle styfle mentioned this pull request Jul 19, 2023
Merged
styfle
styfle requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use #52904 instead

leerob pushed a commit that referenced this pull request Jul 19, 2023
@styfle
chore(docs): fix typo in generate metadata docs (#52904)
b12e6fe 
- See current bug:
https://nextjs.org/docs/app/api-reference/functions/generate-metadata#generatemetadata-function
- Closes #52903
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle requested changes

@ismaelrumzan ismaelrumzan Awaiting requested review from ismaelrumzan ismaelrumzan was automatically assigned from vercel/devex

@steven-tey steven-tey Awaiting requested review from steven-tey steven-tey was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SalvatoreCampagnese @styfle @ijjk