Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Add mentioning of HOSTNAME env variable for standalone output #52804

Merged
merged 2 commits into from
Jul 17, 2023
Merged

chore(docs): Add mentioning of HOSTNAME env variable for standalone output #52804

merged 2 commits into from
Jul 17, 2023

Conversation

steppefox
Copy link
Contributor

What?

Update documentation to mention a HOSTNAME env variable for standalone output

Related to Feature: #44627

Why?

Current documentation mentions only PORT env, but does not mention HOSTNAME added in January

Affected documentation pages:

Affected examples:

How?

  • Run examples
  • Check documentation

@steppefox steppefox requested review from a team as code owners July 17, 2023 19:36
@ijjk ijjk added area: documentation examples Issue was opened via the examples template. labels Jul 17, 2023
@styfle styfle requested a review from balazsorban44 July 17, 2023 19:39
@ijjk
Copy link
Member

ijjk commented Jul 17, 2023 •
edited by styfle
Loading

Allow CI Workflow Run

  • approve CI run for commit: 4c68d57

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@steppefox steppefox force-pushed the chore/docs-standalone-hostname branch from 8326a60 to 4c68d57 Compare July 17, 2023 19:47
@steppefox steppefox requested a review from styfle July 17, 2023 19:49
@steppefox steppefox force-pushed the chore/docs-standalone-hostname branch from 4c68d57 to caf90a4 Compare July 17, 2023 19:51
@steppefox steppefox requested a review from styfle July 17, 2023 19:52
@kodiakhq kodiakhq bot merged commit 0084166 into vercel:canary Jul 17, 2023
@steppefox steppefox deleted the chore/docs-standalone-hostname branch July 17, 2023 20:03
@dunglas dunglas mentioned this pull request Jul 18, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timeyoutakeit timeyoutakeit Awaiting requested review from timeyoutakeit timeyoutakeit was automatically assigned from vercel/devex

@steven-tey steven-tey Awaiting requested review from steven-tey steven-tey was automatically assigned from vercel/devex

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steppefox @ijjk @styfle