-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update TypeScript plugin section for VS Code prompt #52111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delbaoliveira
requested changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
docs/02-app/01-building-your-application/06-configuring/01-typescript.mdx
Outdated
Show resolved
Hide resolved
delbaoliveira
previously approved these changes
Jul 6, 2023
leerob
reviewed
Jul 9, 2023
docs/02-app/01-building-your-application/06-configuring/01-typescript.mdx
Outdated
Show resolved
Hide resolved
docs/02-app/01-building-your-application/06-configuring/01-typescript.mdx
Outdated
Show resolved
Hide resolved
leerob
reviewed
Jul 9, 2023
docs/02-app/01-building-your-application/06-configuring/01-typescript.mdx
Outdated
Show resolved
Hide resolved
leerob
approved these changes
Jul 9, 2023
leerob
changed the title
docs: update typescript plugin section for vscode prompt
docs: Update TypeScript plugin section for VS Code prompt
Jul 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Next.js Team, 👋🏻
I noticed Next.js apps scaffolded with create-next-app weren't prompting me for the TypeScript workspace version in VS Code. After digging through the repo, I stumbled on this #49133 PR from Tim. While this PR explains why it was removed, I'm not sure the docs were ever updated to reflect this change.
This PR aims to address that with a simple note in the TypeScript Plugin section of the TypeScript docs page.