Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: fix redirect on the edge #49197

Merged
merged 2 commits into from
May 4, 2023

Conversation

feedthejim
Copy link
Contributor

@feedthejim feedthejim commented May 4, 2023

  • enables redirect for the edge
  • enables production tests

link NEXT-1086

@ijjk
Copy link
Member

ijjk commented May 4, 2023

Failing test suites

Commit: 64b06cd

pnpm testheadless test/development/acceptance-app/rsc-build-errors.test.ts

  • Error overlay - RSC build errors > should throw an error when error file is a server component with empty error file
Expand output

● Error overlay - RSC build errors › should throw an error when error file is a server component with empty error file

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `Error overlay - RSC build errors should throw an error when error file is a server component with empty error file 1`

- Snapshot  - 1
+ Received  + 1

@@ -7,6 +7,6 @@
   1 |  
     : ^
     `----

  Import path:
- ./app/server-with-errors/error-file/error.js
+   ./app/server-with-errors/error-file/error.js

  303 |       expect(await session.hasRedbox(true)).toBe(true)
  304 |       await check(() => session.getRedboxSource(), /must be a Client Component/)
> 305 |       expect(await session.getRedboxSource()).toMatchInlineSnapshot(`
      |                                               ^
  306 |         "./app/server-with-errors/error-file/error.js
  307 |         ReactServerComponentsError:
  308 |

  at Object.<anonymous> (development/acceptance-app/rsc-build-errors.test.ts:305:47)

Read more about building and testing Next.js in contributing.md.

@kodiakhq kodiakhq bot merged commit aec49ec into canary May 4, 2023
@kodiakhq kodiakhq bot deleted the feedthejim/next-1086-support-redirect-on-the-edge branch May 4, 2023 11:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants