Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: update React.CSSProperties type to Record #49186

Merged
merged 12 commits into from
May 9, 2023
Next Next commit
type: update React.CSSProperties type to Record
  • Loading branch information
li-jia-nan committed May 4, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit c0e04f71dceea7900df6e9b68782495276a1be17
2 changes: 1 addition & 1 deletion packages/next/src/client/components/error.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react'

const styles: { [k: string]: React.CSSProperties } = {
const styles: Record<PropertyKey, React.CSSProperties> = {
li-jia-nan marked this conversation as resolved.
Show resolved Hide resolved
error: {
// https://github.com/sindresorhus/modern-normalize/blob/main/modern-normalize.css#L38-L52
fontFamily:
2 changes: 1 addition & 1 deletion packages/next/src/pages/_error.tsx
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@ function _getInitialProps({
return { statusCode }
}

const styles: { [k: string]: React.CSSProperties } = {
const styles: Record<PropertyKey, React.CSSProperties> = {
li-jia-nan marked this conversation as resolved.
Show resolved Hide resolved
error: {
// https://github.com/sindresorhus/modern-normalize/blob/main/modern-normalize.css#L38-L52
fontFamily: