Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic routes for generateImageMetadata #48928

Merged
merged 9 commits into from
Apr 28, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
check length
huozhi committed Apr 27, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 53343a88f0e685d21d9b886bae26399dc85a14e0
1 change: 1 addition & 0 deletions test/e2e/app-dir/metadata-dynamic-routes/index.test.ts
Original file line number Diff line number Diff line change
@@ -328,6 +328,7 @@ createNextDescribe(
const twitterImage = $('meta[name="twitter:image"]').attr('content')
const ogImages = $('meta[property="og:image"]')

expect(ogImages.length).toBe(2)
ogImages.each((_, ogImage) => {
huozhi marked this conversation as resolved.
Show resolved Hide resolved
const ogImageUrl = $(ogImage).attr('content')
expect(ogImageUrl).toMatch(