Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable app dir export integration test #48291

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Temporarily disable app dir export integration test #48291

merged 1 commit into from
Apr 12, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 12, 2023 •
edited
Loading

As the integration tests are keeping failed on canary, turns out that the require hook didn't set up properly so when running the app-dir-export integration test it breaks others. Will re-enable it once migrated to e2e tests

x-ref: https://github.com/vercel/next.js/actions/runs/4668919790/jobs/8266728783?pr=48252#step:6:149
x-ref: https://github.com/vercel/next.js/actions/runs/4668707070/jobs/8266215431?pr=48252#step:6:325
x-ref: https://github.com/vercel/next.js/actions/runs/4675947717/jobs/8281764592?pr=48276

@ijjk ijjk added area: tests created-by: Next.js team PRs by the Next.js team. labels Apr 12, 2023
@huozhi huozhi marked this pull request as ready for review April 12, 2023 13:22
@huozhi huozhi requested a review from styfle April 12, 2023 13:23
@feedthejim feedthejim merged commit 805183e into vercel:canary Apr 12, 2023
@huozhi huozhi deleted the disable/export-integration-test branch April 12, 2023 13:56
styfle added a commit that referenced this pull request May 5, 2023
@styfle
Revert "Temporarily disable app dir export integration test (#48291)"
e6a0db9 
This reverts commit 805183e.
@styfle styfle mentioned this pull request May 5, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request May 8, 2023
@styfle
Revert "Temporarily disable app dir export integration test" (#49311)
1c005eb 
- Reverts #48291
- Fixes #49059 
- TODO: move these tests to `./tests/e2e/*` to avoid flakes (that will be a follow up PR)
fix NEXT-1092
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@feedthejim feedthejim feedthejim approved these changes

@styfle styfle styfle approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huozhi @styfle @feedthejim @ijjk