Fix hot-reloading of tailwind css on Firefox #47426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroussey
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
feedthejim
as code owners
|
Closing as #43396 was addressed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Browsers do weird things. This works around the fact that if you append a stylesheet in firefox to the end of head, firefox sees it as a duplicate and ignores it. But only at the end apparently. This fix changes the MiniCssExtractPlugin to not use the default insert that just appends to the end of head.
This has another advantage: the css files remain in the same order.
NOTE: the plugin takes the function
insertand does a.toString()on it, so for best compat, best to use old JS as it will not get transpiled.fix NEXT-684 (link)
I messed up my git history and so started over, sorry for new PR @shuding