Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @types/mdx to app-dir-mdx example #46523

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Conversation

Dannymx
Copy link
Contributor

@Dannymx Dannymx commented Feb 28, 2023

The app-dir-mdx is missing @types/mdx thus causing an error: Cannot find module 'mdx/types' or its corresponding type...

Related PR previously added types but was missing the line in package.json

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the examples Issue was opened via the examples template. label Feb 28, 2023
Copy link
Contributor

@jankaifer jankaifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@jankaifer jankaifer enabled auto-merge (squash) March 2, 2023 09:01
auto-merge was automatically disabled March 2, 2023 09:07

Base branch was modified

@kodiakhq kodiakhq bot merged commit a20ce54 into vercel:canary Mar 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants