Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge runtime path slashes mismatch on windows #46302

Merged
merged 6 commits into from
Feb 23, 2023
Merged

Fix edge runtime path slashes mismatch on windows #46302

merged 6 commits into from
Feb 23, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 23, 2023 •
edited
Loading

Closes NEXT-620

Test with app-playground locally on windows VM

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 23, 2023
timneutkens
timneutkens previously approved these changes Feb 23, 2023
View reviewed changes
@huozhi huozhi marked this pull request as draft February 23, 2023 13:55
@huozhi huozhi marked this pull request as ready for review February 23, 2023 13:58
@balazsorban44 balazsorban44 changed the title Fix edge runtim path slashes mismatch on windows Fix edge runtime path slashes mismatch on windows Feb 23, 2023
@shuding shuding merged commit 344ccf2 into vercel:canary Feb 23, 2023
@huozhi huozhi deleted the fix/windows-edge branch February 23, 2023 14:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding approved these changes

@timneutkens timneutkens timneutkens left review comments

@ijjk ijjk Awaiting requested review from ijjk

@feedthejim feedthejim Awaiting requested review from feedthejim

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huozhi @shuding @timneutkens @ijjk