Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API route matched as page on Windows in dev #46238

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Fix API route matched as page on Windows in dev #46238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed96c49
Fix API route matched as page on Windows in dev
Feb 22, 2023
1eef689
Merge branch 'canary' into dev-pages-route-matcher-windows
kodiakhq[bot] Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...es/next/src/server/future/route-matcher-providers/dev/dev-pages-route-matcher-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export class DevPagesRouteMatcherProvider extends FileCacheRouteMatcherProvider<
// so we need to include the pages directory.

// TODO: could path separator normalization be needed here?
if (filename.startsWith(`${this.pagesDir}/api/`)) return false
if (filename.startsWith(path.join(this.pagesDir, '/api/'))) return false

for (const extension of this.extensions) {
// We can also match if we have `pages/api.${extension}`, so check to
Expand Down