Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip collecting modules from page dir in the client reference plugin #46020

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Skip collecting modules from page dir in the client reference plugin #46020

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc695d7
fix skip modules in page dir in flight manifest
shuding Feb 16, 2023
b7cf55f
Merge branch 'canary' into shu/8t6u
shuding Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/next/src/build/webpack/plugins/flight-manifest-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {

import { traverseModules } from '../utils'
import { nonNullable } from '../../../lib/non-nullable'
import { WEBPACK_LAYERS } from '../../../lib/constants'

// This is the module that will be used to anchor all client references to.
// I.e. it will have all the client files as async deps from this point on.
Expand Down Expand Up @@ -161,6 +162,11 @@ export class FlightManifestPlugin {
mod: webpack.NormalModule,
chunkCSS: string[]
) {
// Skip all modules from the pages folder.
if (mod.layer !== WEBPACK_LAYERS.appClient) {
return
}

const isCSSModule =
regexCSS.test(mod.resource) ||
mod.type === 'css/mini-extract' ||
Expand Down