Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested example setup with create-next-app #45390

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 29, 2023

Noticed in #45387 we aren't properly setting up nested examples due to not stripping to the right level so this ensures we handle that case properly.

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team. labels Jan 29, 2023
@ijjk
Copy link
Member Author

ijjk commented Jan 29, 2023

Failing test suites

Commit: f0c8a79

pnpm testheadless test/e2e/app-dir/metadata/metadata.test.ts

  • app dir - metadata > metadata > basic > should apply metadata when navigating client-side
Expand output

● app dir - metadata › metadata › basic › should apply metadata when navigating client-side

page.waitForSelector: Timeout 2000ms exceeded.
=========================== logs ===========================
waiting for locator('#basic')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10
  at Object.<anonymous> (e2e/app-dir/metadata/metadata.test.ts:275:11)

Read more about building and testing Next.js in contributing.md.

@ijjk ijjk marked this pull request as ready for review January 29, 2023 19:52
@ijjk ijjk merged commit b0d951b into vercel:canary Jan 29, 2023
@ijjk ijjk deleted the fix/cna-nested-example branch January 29, 2023 19:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant