Update with-redux example tsconfig to use strict: true #45325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okcoker
requested review from
timneutkens,
ijjk,
shuding,
leerob,
steven-tey and
balazsorban44
as code owners
styfle
changed the title
styfle
approved these changes
Jan 28, 2023
ijjk
approved these changes
Jan 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was updating one of my old next.js v3 apps to v13, and decided to play around with RTK. Using the with-redux example sort of sets users up for some weird typing issues as mentioned here: reduxjs/redux-toolkit#2862
I found that github issue after reading through all the official RTK x TS docs, and it seems it could have all been avoided with stricter typing. I'm hoping RTK can add this bit to their docs soon.