Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: next build in typescript 5.0 #45275

Merged
merged 9 commits into from
Jan 27, 2023
Merged

fix: next build in typescript 5.0 #45275

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
41b0483
fix: next build in typescript 5.0
himself65 Jan 25, 2023
adac3fc
fix: code
himself65 Jan 25, 2023
e82eef8
Merge branch 'canary' into fix-typescript
himself65 Jan 25, 2023
2411fcd
fix: prefer to use Node10
himself65 Jan 25, 2023
d31473a
Merge branch 'canary' into fix-typescript
himself65 Jan 26, 2023
cc289fd
Merge branch 'canary' into fix-typescript
himself65 Jan 26, 2023
7edf5ae
Merge branch 'canary' into fix-typescript
himself65 Jan 26, 2023
d4490ab
Merge branch 'canary' into fix-typescript
himself65 Jan 27, 2023
b0b95c6
Merge branch 'canary' into fix-typescript
ijjk Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/next/src/lib/typescript/writeConfigurationDefaults.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,14 @@ function getDesiredCompilerOptions(
reason: 'for dynamic import() support',
},
moduleResolution: {
parsedValue: ts.ModuleResolutionKind.NodeJs,
// In TypeScript 5.0, `NodeJs` has renamed to `Node10`
parsedValue:
(ts.ModuleResolutionKind as any).Node10 ??
ts.ModuleResolutionKind.NodeJs,
// All of these values work:
parsedValues: [
ts.ModuleResolutionKind.NodeJs,
(ts.ModuleResolutionKind as any).Node10 ??
ts.ModuleResolutionKind.NodeJs,
// only newer TypeScript versions have this field, it
// will be filtered for new versions of TypeScript
(ts.ModuleResolutionKind as any).Node12,
Expand Down