Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure additional windows are not created on Windows OS #45022

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 19, 2023

This ensures we don't create un-necessary command windows for separate processes on Windows. We can't test this in CI consistently although was manually tested on Windows 11.

Before

CleanShot.2023-01-18.at.14.58.25.mp4

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Fixes: #44992

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 19, 2023
@ijjk ijjk marked this pull request as ready for review January 19, 2023 00:41
@ijjk ijjk merged commit 57fb41b into canary Jan 19, 2023
@ijjk ijjk deleted the update/windows-forking branch January 19, 2023 00:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When closing yarn dev in VS Code, new console windows pop up
1 participant