Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get-api-cookie.ts #44466

Merged
merged 3 commits into from
Jan 1, 2023
Merged

Update get-api-cookie.ts #44466

merged 3 commits into from
Jan 1, 2023

Conversation

dirheimerb
Copy link
Contributor

Added the types for req and res.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from [our contributing doc]

Here is the documentation followed Nextjs Link

Added the types for req and res.
@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 31, 2022
leerob
leerob previously approved these changes Dec 31, 2022
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ijjk
ijjk previously approved these changes Jan 1, 2023
@ijjk ijjk dismissed stale reviews from ghost , leerob, and themself via 3cf206e January 1, 2023 00:52
@kodiakhq kodiakhq bot merged commit f7b654e into vercel:canary Jan 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants