-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating errors and information on the edge runtime #43814
Closed
timeyoutakeit
wants to merge
6
commits into
vercel:canary
from
timeyoutakeit:timeyoutakeit/edge-updates
Closed
Updating errors and information on the edge runtime #43814
timeyoutakeit
wants to merge
6
commits into
vercel:canary
from
timeyoutakeit:timeyoutakeit/edge-updates
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feugy
reviewed
Dec 8, 2022
Kikobeats
reviewed
Dec 9, 2022
timeyoutakeit
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi,
padmaia,
leerob and
balazsorban44
as code owners
December 14, 2022 10:19
molebox
requested changes
Dec 14, 2022
docs/basic-features/data-fetching/incremental-static-regeneration.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Rich Haines <[email protected]>
This was referenced Dec 14, 2022
Changes were cherry picked in #44045. |
Landed in #44045. |
6 tasks
ijjk
added a commit
that referenced
this pull request
Jan 3, 2023
## 📖 What's in there? Yesterday we didn't had time to address leftovers from #44045. Here it is. - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added - [ ] Documentation added (from [PR 43814](#43814)) - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md) ## 🧪 How to test? Several tests cases added: - in dev mode, errors and warning: `NEXT_TEST_MODE=dev pnpm testheadless --testPathPattern edge-configurable-runtime` - in build mode, build error for pages on the `edge`: `NEXT_TEST_MODE=start pnpm testheadless --testPathPattern edge-configurable-runtime` Co-authored-by: JJ Kasper <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
pnpm build && pnpm lint