Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pnpm pack for e2e tests #43586

Closed
wants to merge 1 commit into from
Closed

Use pnpm pack for e2e tests #43586

wants to merge 1 commit into from

Conversation

styfle
Copy link
Member

@styfle styfle commented Nov 30, 2022

We shouldn't be mixing yarn and pnpm so this PR replaces yarn pack with pnpm pack

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Nov 30, 2022
@ijjk ijjk force-pushed the canary branch 2 times, most recently from e078ebe to 6b863fe Compare December 2, 2022 05:49
@styfle styfle force-pushed the use-pnpm-pack-e2e-tests branch from c80c1e7 to b8f3572 Compare December 12, 2022 03:04
@timneutkens timneutkens force-pushed the use-pnpm-pack-e2e-tests branch from b8f3572 to 4f639b1 Compare December 13, 2022 11:11
@ijjk ijjk added area: documentation examples Issue was opened via the examples template. labels Dec 13, 2022
@timneutkens timneutkens force-pushed the use-pnpm-pack-e2e-tests branch from 4f639b1 to b8f3572 Compare December 13, 2022 11:27
@jankaifer
Copy link
Contributor

I needed this change in my branch that speeds up our tests:

await exec(`cd ${pkgPath} && pnpm pack`, true)
await exec(
`cd ${pkgPath} && mv *${pkg}-${version}.tgz ${pkg}-packed.tgz`
)

So I borrowed your code. Thanks.

@styfle
Copy link
Member Author

styfle commented Dec 14, 2022

Closing in favor of #44023

@styfle styfle closed this Dec 14, 2022
@styfle styfle deleted the use-pnpm-pack-e2e-tests branch December 14, 2022 14:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants