update font optimization page #42266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismaelrumzan
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi,
padmaia,
leerob and
balazsorban44
as code owners
hanneslund
suggested changes
Nov 1, 2022
| @@ -107,14 +107,14 @@ For usage, review [Local Fonts](/docs/optimizing/fonts#local-fonts). | |||
|
|
|||
| ### `src` | |||
|
|
|||
| The path of the font file as a string relative to the directory where the font loader function is called or to the `app` directory. | |||
| The path of the font file as a string relative to the directory where the font loader function is called or to the `pages` directory. | |||
There was a problem hiding this comment.
The path of the font file as a string relative to the directory where the font loader function is called.
This is correct
or to the
pagesdirectory.
It's always relative to where it's called.
| // app/layout.tsx | ||
| import { Roboto } from '@next/font/google' | ||
| ```js:pages/_app.js | ||
| import { Roboto } from '@next/font/google'; | ||
|
|
||
| const roboto = Roboto({ | ||
| weight: '400', |
There was a problem hiding this comment.
Missing multiple weights/styles in API reference for both google and local.
delbaoliveira
previously approved these changes
Nov 1, 2022
Co-authored-by: Delba de Oliveira <[email protected]>
timneutkens
reviewed
Nov 2, 2022
timneutkens
approved these changes
Nov 2, 2022
timneutkens
approved these changes
Nov 2, 2022
11 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
Fixes syntax errors introduced in #42266 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by: JJ Kasper <[email protected]>
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to using
pages/instead ofapp/Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples
pnpm build && pnpm lint