Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Rename next/image to next/legacy/image & rename next/future/image to next/image #41399

Merged
merged 11 commits into from
Oct 14, 2022
Merged

BREAKING CHANGE: Rename next/image to next/legacy/image & rename next/future/image to next/image #41399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5eb254e
Rename next/image to next/legacy/image
styfle Oct 13, 2022
8deb6d7
Add missing legacy directory
styfle Oct 13, 2022
4a6e439
Rename `next/future/image` to `next/image`
styfle Oct 13, 2022
3e6d61b
Fix unit tests
styfle Oct 13, 2022
4eb6514
Remove test since its not expected for the new component
styfle Oct 13, 2022
08efa04
Fix rsc test
styfle Oct 13, 2022
cc5ddc1
Fix remaining tests
styfle Oct 13, 2022
d01bef2
Fix unit tests
styfle Oct 14, 2022
e15cc3c
Merge branch 'canary' into breaking-rename-next-image
styfle Oct 14, 2022
789c240
Fix lint
styfle Oct 14, 2022
eeceee0
Fix regex test
styfle Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion packages/next/build/webpack-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,7 +1067,7 @@ export default async function getBaseWebpackConfig(
}

const notExternalModules =
/^(?:private-next-pages\/|next\/(?:dist\/pages\/|(?:app|document|link|image|future\/image|constants|dynamic|script|navigation|headers)$)|string-hash|private-next-rsc-mod-ref-proxy$)/
/^(?:private-next-pages\/|next\/(?:dist\/pages\/|(?:app|document|link|image|legacy\/image|constants|dynamic|script|navigation|headers)$)|string-hash|private-next-rsc-mod-ref-proxy$)/
if (notExternalModules.test(request)) {
return
}
Expand Down
2 changes: 2 additions & 0 deletions packages/next/build/webpack/plugins/telemetry-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export type SWC_TARGET_TRIPLE =
export type Feature =
| 'next/image'
| 'next/future/image'
| 'next/legacy/image'
| 'next/script'
| 'next/dynamic'
| 'swcLoader'
Expand Down Expand Up @@ -58,6 +59,7 @@ interface Connection {
const FEATURE_MODULE_MAP: ReadonlyMap<Feature, string> = new Map([
['next/image', '/next/image.js'],
['next/future/image', '/next/future/image.js'],
['next/legacy/image', '/next/legacy/image.js'],
['next/script', '/next/script.js'],
['next/dynamic', '/next/dynamic.js'],
])
Expand Down
Loading