Remove special error script handling #3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result of that, we can't detect 500 errors and buildIdMismatch via client side.
arunoda
changed the title
arunoda
changed the title
timneutkens
reviewed
Feb 21, 2018
| @@ -53,6 +54,18 @@ routerEvents.forEach((event) => { | |||
| }) | |||
| }) | |||
|
|
|||
| const warnAboutRouterOnAppUpdated = execOnce(() => { | |||
| console.warn(`Router.onAppUpdated is removed - visit https://err.sh/next.js/no-on-app-updated-hook for more information.`) | |||
There was a problem hiding this comment.
https://err.sh/next.js/no-on-app-updated-hook (otherwise consoles might not linkify it)
There was a problem hiding this comment.
This is already like that.
timneutkens
approved these changes
Feb 21, 2018
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow us to serve Next.js assets from a static directory and still support zones.
As a result of that, we can't detect 500 errors and buildIdMismatch via client side.