Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update other instances of node-fetch #33617

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 24, 2022

Follow-up to #33466 this ensures we update the other instances of node-fetch.

@ijjk ijjk marked this pull request as ready for review January 24, 2022 21:55
@ijjk ijjk requested review from balazsorban44 and styfle January 24, 2022 21:56
@ijjk
Copy link
Member Author

ijjk commented Jan 24, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/fetch-dep Change
buildDuration 15s 14.9s -61ms
buildDurationCached 5s 3.7s -1.3s
nodeModulesSize 355 MB 356 MB ⚠️ +295 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/fetch-dep Change
/ failed reqs 0 0
/ total time (seconds) 3.592 3.607 ⚠️ +0.02
/ avg req/sec 696.04 693.04 ⚠️ -3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.725 1.681 -0.04
/error-in-render avg req/sec 1449.2 1486.87 +37.67
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/fetch-dep Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/fetch-dep Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/fetch-dep Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.87 kB 4.87 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.2 kB 14.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/fetch-dep Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/fetch-dep Change
index.html gzip 530 B 530 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/fetch-dep Change
buildDuration 18s 18.3s ⚠️ +342ms
buildDurationCached 3.8s 3.7s -41ms
nodeModulesSize 355 MB 356 MB ⚠️ +295 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/fetch-dep Change
/ failed reqs 0 0
/ total time (seconds) 3.501 3.431 -0.07
/ avg req/sec 714.14 728.61 +14.47
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.638 1.536 -0.1
/error-in-render avg req/sec 1526.01 1627.18 +101.17
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/fetch-dep Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/fetch-dep Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/fetch-dep Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.89 kB 4.89 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.2 kB 14.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/fetch-dep Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/fetch-dep Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB
Commit: e4989e3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants