Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add native package folders and ensure wasm artifacts are downloaded #31561

Merged
merged 4 commits into from
Nov 18, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 18, 2021

Follow-up to #31470 this re-adds the package folders and their package.jsons as it seems they got removed in the previous PR but are still needed. This also ensures the publish job relies on build-wasm and the artifacts from that job are downloaded.

Fixes: https://github.com/vercel/next.js/runs/4245263631?check_suite_focus=true

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Nov 18, 2021
@ijjk ijjk marked this pull request as ready for review November 18, 2021 01:20
@ijjk ijjk requested a review from styfle as a code owner November 18, 2021 01:22
@ijjk ijjk marked this pull request as draft November 18, 2021 01:24
@ijjk ijjk changed the title Re-add native package folders and update publish-native Re-add native package folders Nov 18, 2021
@ijjk ijjk changed the title Re-add native package folders Re-add native package folders and ensure wasm artifacts are downloaded Nov 18, 2021
@ijjk ijjk marked this pull request as ready for review November 18, 2021 01:35
@ijjk
Copy link
Member Author

ijjk commented Nov 18, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/publish-native Change
buildDuration 22.5s 23.1s ⚠️ +600ms
buildDurationCached 4.1s 4.4s ⚠️ +344ms
nodeModulesSize 338 MB 338 MB -8 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/publish-native Change
/ failed reqs 0 0
/ total time (seconds) 4.011 4.034 ⚠️ +0.02
/ avg req/sec 623.28 619.71 ⚠️ -3.57
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.143 2.036 -0.11
/error-in-render avg req/sec 1166.62 1227.99 +61.37
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/publish-native Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/publish-native Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/publish-native Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/publish-native Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/publish-native Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 518 B 518 B
Overall change 1.58 kB 1.58 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/publish-native Change
buildDuration 23.8s 24.3s ⚠️ +516ms
buildDurationCached 4.2s 4.3s ⚠️ +76ms
nodeModulesSize 338 MB 338 MB -8 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/publish-native Change
/ failed reqs 0 0
/ total time (seconds) 3.835 3.953 ⚠️ +0.12
/ avg req/sec 651.85 632.35 ⚠️ -19.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.202 2.153 -0.05
/error-in-render avg req/sec 1135.35 1161.42 +26.07
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/publish-native Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/publish-native Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/publish-native Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/publish-native Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/publish-native Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: 9f091e9

@ijjk ijjk merged commit be2e863 into vercel:canary Nov 18, 2021
@ijjk ijjk deleted the fix/publish-native branch November 18, 2021 02:23
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants