Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade webpack-sources #30944

Merged
merged 3 commits into from
Nov 4, 2021
Merged

upgrade webpack-sources #30944

merged 3 commits into from
Nov 4, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 4, 2021

fixes #30920

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Nov 4, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 4, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js upgrade/webpack-sources Change
buildDuration 22.1s 23.1s ⚠️ +982ms
buildDurationCached 4.2s 4.3s ⚠️ +106ms
nodeModulesSize 293 MB 293 MB ⚠️ +210 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js upgrade/webpack-sources Change
/ failed reqs 0 0
/ total time (seconds) 3.729 4.147 ⚠️ +0.42
/ avg req/sec 670.38 602.85 ⚠️ -67.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.938 2.212 ⚠️ +0.27
/error-in-render avg req/sec 1290.1 1130.39 ⚠️ -159.71
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js upgrade/webpack-sources Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js upgrade/webpack-sources Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js upgrade/webpack-sources Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js upgrade/webpack-sources Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js upgrade/webpack-sources Change
index.html gzip 522 B 522 B
link.html gzip 533 B 533 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js upgrade/webpack-sources Change
buildDuration 23.7s 27.9s ⚠️ +4.2s
buildDurationCached 4.2s 4.1s -151ms
nodeModulesSize 293 MB 293 MB ⚠️ +210 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js upgrade/webpack-sources Change
/ failed reqs 0 0
/ total time (seconds) 3.573 4.501 ⚠️ +0.93
/ avg req/sec 699.61 555.42 ⚠️ -144.19
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.008 2.378 ⚠️ +0.37
/error-in-render avg req/sec 1244.95 1051.21 ⚠️ -193.74
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js upgrade/webpack-sources Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js upgrade/webpack-sources Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js upgrade/webpack-sources Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js upgrade/webpack-sources Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js upgrade/webpack-sources Change
index.html gzip 522 B 522 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: b7dedd9

@sokra sokra marked this pull request as ready for review November 4, 2021 11:32
@kodiakhq kodiakhq bot merged commit c7d0883 into canary Nov 4, 2021
@kodiakhq kodiakhq bot deleted the upgrade/webpack-sources branch November 4, 2021 11:33
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to webpack-sources 3.2.1
3 participants